Release Genshin-style ToonShader validation v1.2.1 - #1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Celerant to v1.2.1 alongside the MCglTF 26.2-Fabric-2.3.2.6 dependency, and strengthens ToonShader validation by expanding the client GameTest shader-pack matrix to capture additional “restored” and directional-light visual evidence plus pixel-stability metrics.
Changes:
- Bump MCglTF dependency (and mod metadata/docs) from 2.3.2.5 to 2.3.2.6 and update the mod version to 1.2.1.
- Extend
CelerantClientGameTestshader-pack matrix to capture restored/directional ToonShader evidence crops (native + 4× nearest) and add restored pixel stability metrics to the TSV. - Update documentation (README/AGENTS) and changelog with mandatory visual gates and the one-pack-per-JVM test protocol.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/fabric.mod.json | Updates runtime dependency requirement to MCglTF 26.2-Fabric-2.3.2.6. |
| src/gametest/java/io/github/westernbear/celerant/client/CelerantClientGameTest.java | Adds restored + directional evidence capture and restored stability metrics to shader-pack matrix TSV. |
| README.md | Updates dependency link/version and documents updated validation claims/procedure. |
| gradle.properties | Bumps mod version to 1.2.1 and MCglTF version property to 2.3.2.6. |
| CHANGELOG.md | Adds 1.2.1 release notes describing updated ToonShader validation and pack matrix procedure. |
| build.gradle | Adds optional localMcgltf override while keeping JitPack MCglTF as default. |
| AGENTS.md | Renames/expands ToonShader acceptance criteria and mandatory visual evaluation procedure. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1114
to
+1118
| } finally { | ||
| world.getServer().runCommand("time set 6000"); | ||
| connection.waitForClientboundPackets(); | ||
| context.waitTicks(20); | ||
| } |
| metric(off.frames().p95Ms()), metric(off.frames().p99Ms()), tsvPath(off.image()), | ||
| tsv(off.irisError()), Boolean.toString(off.packInUse()), tsv(off.error()), metric(restored.reloadMs()), tsvPath(restored.image()), | ||
| tsv(restored.irisError()), Boolean.toString(restored.packInUse()), tsv(restored.error()), Boolean.toString(toon.detected()), | ||
| tsv(restored.irisError()), Boolean.toString(restored.packInUse()), tsv(restored.error()), "18", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
./gradlew clean build --no-daemon --max-workers=1runClientGameTestwith remote JitPack dependency6e7cfc18e8ea43ed475afeab24782d3e807fa7f8bee9f32c2b3e76e7ff2fca7c