fix(equipment): show HLT + mash-tun for default (unset) mash mode - #57
Merged
Conversation
The single-vessel work (#47) changed the HLT/mash-tun section guards to `mash_mode === "classic"`, but mash_mode is optional and is undefined on fresh profiles (the dropdown shows 'classic' via `?? "classic"`). undefined === "classic" is false, so the sections — including the mash-thickness field — vanished for any profile that hadn't explicitly set the mode. Guard on `!== "biab" && !== "single_vessel"` instead so the default shows them. Fixes the red 'mash thickness persists' e2e on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red e2e on main (
Equipment — BIAB mash mode › mash thickness persists across navigation).Cause: the single-vessel work (#47) changed the HLT/mash-tun visibility guards to
mash_mode === "classic". Butmash_modeis optional and isundefinedon a fresh profile (the dropdown only displays "classic" via?? "classic").undefined === "classic"is false, so both sections — including the mash-thickness field the e2e drives — disappeared for any profile that hadn't explicitly set the mode.Fix: guard on
mash_mode !== "biab" && mash_mode !== "single_vessel"so the default (unset) and explicit "classic" both show the vessels; biab + single_vessel still hide them.Unit suite (360) + lint green locally; the e2e that failed exercises exactly this path.