feat(editor): reorder hop additions (#42) + fix yeast-nutrient timing (#45) - #54
Merged
Merged
Conversation
…#45) #42: hop rows get up/down reorder controls (generic moveRow added to useIngredientRows), so additions can be reordered without delete + re-add. #45: DAP / Fermaid-K default use changed from add_to_boil to add_to_fermentation (dosed at pitching). Servomyces stays a boil addition per the maker's instructions — the feedback specifically called out DAP/Fermaid-K.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more from Phase 5 (third forum batch, Pedzouille). Closes #42 and #45.
#45 — yeast nutrient timing
DAP / Fermaid-K were defaulting to the boil (10 min). They're dosed at pitching (or staggered early in fermentation), not boiled — so the default
useis nowadd_to_fermentation.Kept correct: Servomyces stays a boil addition — it genuinely is added in the last ~10 min of the boil per Lallemand's instructions. The feedback specifically called out DAP/Fermaid-K, so only that entry changed.
#42 — reorder hop additions
Hop rows can't be reordered without deleting + re-adding. Added up/down controls (a generic
moveRowonuseIngredientRows, so the other sections can adopt it later), letting you order additions by time (60 → 15 → flameout → dry hop) in place. Disabled at the ends; mobile-friendly (no drag-and-drop dependency).Tests
moveRow(swap down/up, no-op at both ends).add_to_fermentation, Servomyces =add_to_boil.Verification
pnpm typecheck·pnpm lint·pnpm test(358) ·vite build— all clean.