Repository navigation
Conversation
Every image job built ci/image-tests/Dockerfile from the cache of the job image-test-runner. Even with every step cached, BuildKit asks Docker Hub for the metadata of php:8.4-cli-alpine and composer:2, so each run sent about 300 anonymous requests to Docker Hub, and jobs failed with "429 Too Many Requests" in that step. The job image-test-runner now exports the runner per architecture as an archive for docker load (type=docker) and uploads it as the artifact webdevops-image-tests-<arch>, still with the cache of GitHub Actions. The image jobs download it and load it with docker load, without a request to Docker Hub. Only if the download or the load fails, e.g. because that job could not build the runner, they build it themselves from the cache as before. CONTRIBUTING.md, AGENTS.md and the comment in the Makefile describe the new way.
Kanti
force-pushed
the
c/laughing-carson-ppsduw
branch
from
November 17, 2026 16:42
47093a2 to
221011e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
Every image job built
ci/image-tests/Dockerfileitself, withcache-fromthe cache that the jobimage-test-runnerwrites. Even when every step comes from the cache, BuildKit resolves the metadata ofphp:8.4-cli-alpineandcomposer:2on Docker Hub, anonymously: about 300 requests per run. On 2026-11-17 two jobs failed in that step withfailed to resolve source metadata for docker.io/library/composer:2: ... 429 Too Many Requests:Change
image-test-runnerbuilds the runner as before, with the cache of GitHub Actions, but exports it as an archive fordocker load(outputs: type=docker,dest=.ci-image-test-runner/webdevops-image-tests.tar) and uploads it as the artifactwebdevops-image-tests-<arch>: kept for one day, replaced on a rerun, not compressed again (its layers are gzip-compressed already).docker load --input .ci-image-test-runner/webdevops-image-tests.tar, without a request to Docker Hub.continue-on-error, and only if one of them fails, e.g. becauseimage-test-runnercould not build or upload the runner, the step "Build the image test runner" runs as before, from the cache. The build and upload steps ofimage-test-runnerkeepcontinue-on-error, so a failure there does not skip the image jobs.GITHUB_TOKEN, so the runner job could not push the runner there. Artifacts work for them, as they do for the OCI layouts of the parent images.Documentation
CONTRIBUTING.md, section "Image tests": the jobimage-test-runnerpasses the runner on as an artifact, the image jobs load it withdocker load, and if that fails they build it themselves.AGENTS.mdand the comment in theMakefile: the CI loads the runner instead of building it.Verification
ci/console generate(the command ofmake generate): only.github/workflows/build.yamlchanges.make check): composer, phpcs, PHPStan, Rector, Fractor, composer audit and PHPUnit pass. New tests check that the runner job exports and uploads the archive, that the image jobs download and load it and build the runner only if that fails, and that everysteps.<id>in anifrefers to an earlier step of the same job. They fail against the oldGithubJobBuilder.docker buildx build --tag webdevops-image-tests --output type=docker,dest=<missing dir>/webdevops-image-tests.tarcreates the directory and names the image after the tag, with thedockerand thedocker-containerdriver.docker loadof the archive giveswebdevops-image-tests:latest, andmake test-image-run IMAGE=webdevops/php:8.4-alpinewith the loaded runner passes (137 tests, 5 skipped).base:alpine,php:8.4andphp:8.4-alpineon both architectures,php-nginx:8.3on arm64) showLoaded image: webdevops-image-tests:latestand noload metadatafordocker.io/library/phpordocker.io/library/composer; only the two runner jobs still ask Docker Hub for them.