Repository navigation
[BUGFIX] Report the version of imagick instead of @PACKAGE_VERSION@ - #626
Merged
Merged
Conversation
The images build imagick from its Git branch master, where the version in
php_imagick.h is the placeholder @PACKAGE_VERSION@; only the packaging of
PECL fills it in. phpversion('imagick') returned the placeholder, and
libraries that compare it, e.g. TCPDF, took the wrong path. The build now
fills in the version of package.xml before it compiles imagick.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The images build imagick from its Git branch
master, where the version inphp_imagick.his the placeholder@PACKAGE_VERSION@; only the packaging of PECL fills it in.phpversion('imagick')returns the placeholder, and libraries that compare it, for example TCPDF, take the wrong path. The build now fills in the version ofpackage.xmlbefore it compiles imagick.Related issue: #422 (
phpversion('imagick')returns@PACKAGE_VERSION@), closed, but it still applies to the published images.Changes
template/Dockerfile/images/php.twig: after the clone of imagick, the release ofpackage.xmlreplaces the placeholder (Debian and Alpine);make generate.testImagickReportsItsVersioninPhpChecks:phpversion('imagick')is a version number.How it was verified
php:8.5-alpinefails the new test:'@PACKAGE_VERSION@'.master(today):php_imagick.hhas#define PHP_IMAGICK_VERSION "@PACKAGE_VERSION@"; after thesedcall of the template it is"3.8.1", the release inpackage.xml.sedcall inphp:8.5-fpm-alpine(docker-php-ext-install imagick):phpversion("imagick")is3.8.1, andversion_compare(…, "3.0.0", ">=")is true.ci/console generatechanges nothing.The CI run of this pull request builds every PHP image and runs the new test on Debian and Alpine, amd64 and arm64.