Repository navigation
Conversation
This was referenced Nov 8, 2026
Kanti
force-pushed
the
ccr-0d93296f-2pkfit
branch
from
November 9, 2026 13:16
2e6c4ea to
d74cae8
Compare
There was a problem hiding this comment.
SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Kanti
force-pushed
the
ccr-0d93296f-2pkfit
branch
2 times, most recently
from
November 12, 2026 20:44
72792ba to
860f23f
Compare
Add webdevops/php, php-dev, php-nginx, php-nginx-dev, php-apache and php-apache-dev 8.6 (Debian and Alpine) based on the official PHP 8.6 release candidate images. - Debian 8.6 uses trixie: GD in PHP 8.6 needs libavif >= 1.0.0, which bookworm does not ship. PHP 8.2-8.5 stay on bookworm. - The official 8.6 images no longer bundle mbstring; build it with oniguruma. - vips and xmlrpc are not built for PHP 8.6: both are abandoned upstream and do not build against 8.6. They remain in the 8.2-8.5 images. - ionCube is only installed up to PHP 8.5, also once ionCube supports newer versions. Its loader for thread-safe PHP needs Zend signals, which the official 8.6 images are built without. An image test checks the ionCube Loader in the Debian 8.2-8.5 images and its absence in Alpine and 8.6. - Install the memcached runtime library explicitly; on trixie it was removed together with the purged dev packages. - Thread-safe PHP counts the elapsed time, waiting included, towards max_execution_time. An image test checks this; the tests of PHP-FPM and web server timeouts lift PHP's time limit for their requests. Temporary workarounds until upstream releases support PHP 8.6 (marked "TODO PHP 8.6"): - release candidate base images; the version test accepts RCs for 8.6 - apcu, excimer, memcached, yaml and redis from their development branches via PIE - amqp from the unmerged fix php-amqp/php-amqp#638 (pinned commit) - protobuf: replace the removed zval_dtor() alias - Xdebug from the 3.6 pre-releases - no Tideways in the Debian 8.6 dev images: tideways-php 5.47.0 crashes PHP 8.6 (ZTS) on startup - Alpine dev images install the Blackfire probe directly: `blackfire php:install` picks the glibc probe on Alpine with ZTS Template cleanups that avoid new distribution switches (all Debian images): - signed-by keyrings for the nginx.org and Tideways repositories instead of apt-key (removed in trixie) - bind9-dnsutils and libfreetype-dev instead of transitional packages - libc-client packages only for PHP 8.2/8.3 (imap) - oniguruma packages installed unconditionally
Kanti
force-pushed
the
ccr-0d93296f-2pkfit
branch
from
November 16, 2026 23:02
860f23f to
a791017
Compare
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR stays a draft until every workaround below is gone. Each one is marked
TODO PHP 8.6in the templates and tests.php:8.6-rc-fpm-trixie/php:8.6-rc-fpm-alpine(currently 8.6.0RC7). Once PHP 8.6.0 is out (planned for 2026-11-19), switch tophp:8.6-fpm-trixie/php:8.6-fpm-alpine.ci/image-tests/Checks/PhpChecks.php, remove8.6fromRELEASE_CANDIDATE_PHP_VERSIONSand raise the 8.6 minimum (8.6.0RC7) to the first stable release.apcu/apcu:dev-master: 5.1.28 fails onXtOffsetOf()andphp_verror()(The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed in php 8.6 (master) krakjoe/apcu#605, [BUGFIX] Enable contrib and non-free in the Debian PHP images #616, [BUGFIX] Pass the requested host name to PHP as SERVER_NAME in Nginx #621, [BUGFIX] Deliver mail with UTF-8 in its headers to relay hosts without SMTPUTF8 #629).wikimedia/excimer:dev-master: 1.2.7 fails to build.php-memcached/php-memcached:dev-master: 3.4.0 fails to build.pecl/yaml:dev-php7: 2.3.0 fails onzval_dtor().phpredis/phpredis:dev-develop: 6.3.0 fails onINI_INT().58edfb5e51a49cd10174cdfb18c73a539892d53d, because PHP 8.6 removedXtOffsetOf()andINI_STR/INT/FLT().mainstill call the removedzval_dtor(), so the build replaces it withzval_ptr_dtor_nogc()([PHP] support for upcoming PHP 8.6 protocolbuffers/protobuf#29723).xdebug/xdebug:^3.6@alpha(currently 3.6.0alpha1), because Xdebug 3.5.x requiresphp <8.6.-devimages.tideways-php5.47.0 shipstideways-php-8.6-zts.so, but loading it crashes PHP 8.6 (ZTS) with a segmentation fault on startup.blackfire php:install(CLI 2026.11.0) installs the glibc probe on Alpine with ZTS, soblackfire.sofails to load. The Alpine-devimages download thealpine/<arch>/86-ztsprobe directly.Breaking changes (PHP 8.6 images only)
vipsandxmlrpc. Both are abandoned upstream and do not build against PHP 8.6; the 8.2–8.5 images keep them. Migration notes are in docs/images/php.md:jcupitt/vips2.x via FFI (withphp.ffi.enable: "true"for PHP-FPM), and a userland XML-RPC library.30-setup-ioncube.shskips it from PHP 8.6 on, before the download. Today it would not work anyway: the ionCube loader for thread-safe PHP needs Zend signals, which the official ZTS images are built without (undefined symbol: zend_signal_globals_offset). Applications that need ionCube stay on PHP 8.5.libavif >= 1.0.0.pecl/pear, no built-inmbstringin the official images (remove zts, instead all images are always built as zts (8.6+) docker-library/php#1686, Drop--with-pearwith PHP 8.6 docker-library/php#1654).mbstringis compiled with oniguruma.max_execution_timecounts waiting. Thread-safe PHP measuresmax_execution_time(PHP_MAX_EXECUTION_TIME) with Zend Max Execution Timers, as elapsed time: time spent insleep(), waiting for an HTTP response or forexec()counts, and PHP stops the script with the fatal error once the call returns. Up to PHP 8.5 only the time PHP itself runs counts. Documented indocs/images/php.mdanddocs/environment-variables.md.Changes
php,php-dev,php-nginx,php-nginx-dev,php-apacheandphp-apache-devwith8.6(Debian 13) and8.6-alpine. TheirDockerfile.twigfiles match the 8.5 ones apart from the base image anddistribution='trixie';conf/console.ymlsets Debian 13 for the image tests of8.6.template/Dockerfile/images/php.twighandles the trixie package names and the 8.6 differences;php-extensions.twighas the PIE list for 8.6, the protobuf patch, vips/xmlrpc up to 8.5 and the helper macrosamqpCheckoutandxdebugfor the 8.6 workarounds.ImageUnderTest::hasVipsAndXmlrpc()(likehasImap(), with a unit test inci/tests) limitsvipsandxmlrpcinPhpModulesto PHP 8.2–8.5.ImageUnderTest::hasIonCube()(Debian up to PHP 8.5, also with a unit test) drives the newPhpChecks::testIonCubeLoaderUpToPhp85OnDebian(), which checks that the Debian 8.2–8.5 images load the ionCube Loader and that the Alpine images and PHP 8.6 have none.ImageUnderTest::isThreadSafe()(PHP 8.6 and later, with a unit test) drivesPhpChecks::testPhpThreadSafety()andPhpEnvironmentChecks::testPhpMaxExecutionTimeCountsWaitingOnlyInThreadSafePhp(). Thesleeprequest of the test page takestime_limit=0, which the tests ofFPM_REQUEST_TERMINATE_TIMEOUT,FPM_PROCESS_MAXandWEB_PHP_TIMEOUTuse, so thatPHP_MAX_EXECUTION_TIME=1does not end their requests first on 8.6.PhpCheckshas the 8.6 minimum version and accepts release candidates for 8.6 only.tests/structure-test/php/test.yamlchecksvipsandxmlrpcfor PHP 8.5 and older only.Changes that also affect the 8.2–8.5 images
These avoid new distribution or version switches in the templates:
signed-bykeyrings instead ofapt-key, which trixie no longer has, and nginx.org is used over HTTPS. This fixes the known issue Package sources in the Debian Nginx images, so its entry is removed fromdocs/known-issues.md.bind9-dnsutilsandlibfreetype-devreplace the transitional packagesdnsutilsandlibfreetype6-dev.libc-clientpackages are only installed for PHP 8.2/8.3, which need them for imap.30-setup-ioncube.sh, which every PHP image contains, has the new version check; the 8.2–8.5 images still install ionCube, as the new image test confirms.libmemcached11t64would otherwise be removed together with the dev packages.SonarCloud
The quality gate fails because SonarCloud counts the generated files of the new 8.6 tags (
docker/**/Dockerfile,docker/**/conf/**, workflow jobs) as new code. Almost all findings are identical in the 8.2–8.5 files (installer pipes, unpinned actions, shell style). Thecurlcalls this PR adds (nginx.org and Tideways keys, Blackfire Alpine probe) enforce HTTPS (--proto '=https' --proto-redir '=https'). Excluding the generated files from the analysis is a separate change.Documentation
The 8.6 details are in
docs/images/php.md(section PHP 8.6 (preview)); the README lists the tags, andCONTRIBUTING.mdnotes that Vips and XML-RPC are only built up to PHP 8.5. Each documented change and the check that confirmed it:docs/images/php*.md: tags8.6/8.6-alpine, base images, Debian 13-t "webdevops/..."lines of the generated workflow;/etc/debian_versionis13.7,/etc/alpine-releaseis3.24.4php.md: ZTS, nopeclphp -vshows(ZTS),command -v pecl pearfinds nothing (Debian and Alpine); image testtestPhpThreadSafetyphp.md,environment-variables.md: in 8.6,max_execution_timecounts waiting timeset_time_limit(1),sleep(3),file_get_contents()of a response that takes 3 s andexec('sleep 3')end withMaximum execution time of 1 second exceededinphp:8.6andphp:8.6-alpine;php:8.5completes all three and stops only busy code. Image testtestPhpMaxExecutionTimeCountsWaitingOnlyInThreadSafePhpchecks it through PHP-FPM;php-fpm -ishows the default300php.md: extension table with an8.6column:vips,xmlrpc, ionCube missing in 8.6;lexbor,uripresentphp -minphp:8.6andphp:8.6-alpinephp.md: ionCube only on Debian up to PHP 8.5, not in 8.6 and latertestIonCubeLoaderUpToPhp85OnDebianpasses on the publishedphp:8.5(ionCube Loader v15.5.1) andphp:8.5-alpineand on all 12 8.6 images, and fails whenphp:8.5is tested with the 8.6 expectations; a Debian 8.5 build of this branch still installs ionCubephp.md: FFI only on CLI and preloading by default,php.ffi.enablefor PHP-FPMphp-fpm -ishowsffi.enable => preload, andOnwith the variable; an HTTP request tophp-nginx:8.6returns the result of an FFI callphp.md: no Tideways, Xdebug 3.6 pre-release in-devphp -min all six-devimages; Xdebug 3.6.0alpha1known-issues.md: nginx package sources entry removedphp-nginx:8.5andphp-nginx:8.6built from this branch: nosources.list, notrusted.gpg, an appended backports line works andapt-get updateprints no warnings (the publishedphp-nginx:8.5shows the issue)known-issues.md: Alpine 3.20 repository also applies to8.6-alpine/etc/apk/repositoriesinphp:8.6-alpinecontains the v3.20 lineknown-issues.md: Composer 1 deprecations also on 8.6COMPOSER_VERSION=1,composer --versionprints deprecation notices on 8.6docs/README.md: diagram listsphp:8.6-rc-fpm-trixieci/console generate:readme-banner, part ofmake generate(showsbookworm: 8.2–8.5; trixie: 8.6)Verification
Checked locally in a sandbox on 8.6.0RC7 (amd64):
make generateproduces no further diff. All existing workflow jobs are unchanged; there are 24 new 8.6 jobs.make checkpasses.php,php-dev,php-nginx,php-nginx-dev,php-apacheandphp-apache-dev, each for Debian trixie and Alpine.php -mruns without warnings, and every module of the image tests' list is present.ci/console test:imagepasses for all 12 PHP 8.6 images (local builds as--reference): 140 to 203 tests per image, no failures; the skipped tests (e.g. 2 forphp:8.6, 5 forphp:8.6-alpine) are the same as for the 8.5 images. With the changed tests, the publishedphp:8.5,php:8.5-alpine,php-nginx:8.5andphp-apache:8.5pass as well.tests/structure-testsuites were replayed with a small local runner (thecontainer-structure-testbinary was not available); all differences also show up for the published 8.5 images in that runner.api.github.com. For the local build, mongodb was built from its2.5.7tag instead of via PIE; the PIE path is the same as on 8.5.