Repository navigation
feat(gpui): hold off App Nap during batches and remember the window state - #96
Merged
Merged
Conversation
The bridge acquires gpui's idle-sleep prevention (a user-initiated activity on macOS) when a batch starts and releases it once the batch has settled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The main window reopens on the display it was on (by UUID), at its last windowed rectangle in display-local coordinates, maximized or in full screen as it was left. A rectangle that would show too little of the window, or a display that is gone, falls back to a centred default. The state is saved to gpui-window-state.json from the quit coordinator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zoom and full-screen animations pass through windowed frames, which became the restore rectangle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The close button and the menus quit inside the window's update, where the quit hook cannot read the window; the mode is now followed on every bounds change, and the opening place seeds the state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leaving full screen resizes the window before AppKit reports the exit, so the mode noted on that resize still read full screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
生命周期修复计划 PR-D：
gpui-window-state.json（不改与 Tauri 共享的 settings.json）验证
pmset -g assertions出现 PreventUserIdleSystemSleep "Converting images"，结束后消失；位置/尺寸精确恢复；全屏 ⌘Q 后重启仍全屏，退出全屏回到原位；最大化关闭后重启仍最大化，再缩放回到原尺寸；退出全屏后立即关闭保存为窗口化🤖 Generated with Claude Code