Skip to content

fix(graph): never offer a task itself as its missing dependency - #5328

Merged
Exelord merged 1 commit into
mainfrom
claude/project-thread-8qy6yu
Nov 18, 2026
Merged

Exelord merged 1 commit into
mainfrom
claude/project-thread-8qy6yu

Conversation

@Exelord

@Exelord Exelord commented Nov 18, 2026

Copy link
Copy Markdown
Member

A dependsOn that names a moved project no longer tells the task to depend on itself.

Before

packages/b#build: dependsOn packages/a#build, but no project is named packages/a. Did you mean packages/b#build?

After

packages/b#build: dependsOn packages/a#build, but no project is named packages/a

How it works

nearestTarget already skips the targets the list has. The task's own id joins that set, so the nearest other target is offered, or none.

Breaking changes

None.

Proof

tests/task-graph.test.ts, "a pkg#task miss never offers the task itself": fails without the fix (the message ends in Did you mean packages/b#build?); its control shows another near target is still offered.


Generated by Claude Code

After a project moved, the one task near the old name was its
dependant, and the refusal said to depend on itself:
packages/b#build names packages/a#build, fix: use packages/b#build.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6xuYbJ4nYmSNRHVnNwVx2
@Exelord
Exelord merged commit 93d6a41 into main Nov 18, 2026
12 of 14 checks passed
@Exelord
Exelord deleted the claude/project-thread-8qy6yu branch November 18, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants