Repository navigation
fix(graph): never offer a task itself as its missing dependency - #5328
Merged
Merged
Conversation
After a project moved, the one task near the old name was its dependant, and the refusal said to depend on itself: packages/b#build names packages/a#build, fix: use packages/b#build. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6xuYbJ4nYmSNRHVnNwVx2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
dependsOnthat names a moved project no longer tells the task to depend on itself.Before
After
How it works
nearestTargetalready skips the targets the list has. The task's own id joins that set, so the nearest other target is offered, or none.Breaking changes
None.
Proof
tests/task-graph.test.ts, "a pkg#task miss never offers the task itself": fails without the fix (the message ends inDid you mean packages/b#build?); its control shows another near target is still offered.Generated by Claude Code