Skip to content

chore: Lock remaining installed workflow action dependencies (#34) - #35

Merged
efraespada merged 1 commit into
developfrom
chore/34-lock-remaining-installed-workflow-action-dependencies
Nov 18, 2026
Merged

efraespada merged 1 commit into
developfrom
chore/34-lock-remaining-installed-workflow-action-dependencies

Conversation

@efraespada

@efraespada efraespada commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

The generated lockfile now records reviewed commit resolutions for action steps across all installed workflows, including write-enabled hotfix and release workflows. This lets GitHub enforce those resolutions while preserving the workflows’ complete release tags and reviewed runner placement.

What changed

  • Added lockfile coverage and commit resolutions for action steps in all installed workflows.
  • Added an architecture check that compares each installed workflow’s action steps with the lockfile and validates recorded commit formats.
  • Documented that job-level reusable workflow calls are excluded from the caller lockfile’s coverage.

Validation

  • Frozen offline installation completed.
  • Strict TypeScript checks and both Svelte checks passed with zero errors and warnings.
  • All 16 architecture checks passed.
  • gh actions-lock --verify passed with zero findings; existing CI, npm, and Pages resolutions matched their prior generated entries.

Review notes

  • Job-level reusable workflow calls remain outside the caller lockfile; the documentation records this separate resolution limitation.

Closes #34

@docs-page

docs-page Bot commented Nov 18, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/ha-ui~35

Documentation is deployed and generated using docs.page

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 18, 2026
@vypbot vypbot changed the title Lock installed workflow action resolutions behind released tags chore: Lock remaining installed workflow action dependencies (#34) Nov 18, 2026
@vypbot
vypbot self-requested a review November 18, 2026 20:08
@vypbot vypbot added this to vypdev Nov 18, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 18, 2026
@vypbot
vypbot changed the base branch from develop to master November 18, 2026 20:09
@efraespada efraespada linked an issue Nov 18, 2026 that may be closed by this pull request
1 task done
@vypbot vypbot added the size: S Label to indicate a task of size S label Nov 18, 2026
@vypbot
vypbot changed the base branch from master to develop November 18, 2026 20:09
@vypbot vypbot added the 80% Progress: 80% label Nov 18, 2026
@vypbot

vypbot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on e06ad8d.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@vypbot

vypbot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: e06ad8dc9e77; base: 42abe4563a37; reason: protected-path.

@efraespada

Copy link
Copy Markdown
Member Author

Verified exact head e06ad8dc9e773918fc7dd4f51b222307eb059e30.

  • CI 44387294985 passed on its first attempt in the vypdev self-hosted Apple Silicon pool. All 91 test files and 1,478 tests passed with 100% statement, branch, function and line coverage. Compiled package consumers, catalog browser checks and the specification SDK checks passed.
  • The generated lockfile covers all 18 installed workflows. gh actions-lock --verify passed with zero findings, and the prior CI, npm and Pages resolutions were compared with their reviewed entries.
  • Exact-head Branch Sync, Commit, Verification and PR Review succeeded. The final review has zero threads. Strict types, both Svelte checks and all 16 architecture assertions also passed locally.

This supplies the ordinary-action lockfile correction requested by the review of #33. Continue through exact destination CI and Branch Sync before promoting develop.

@efraespada
efraespada merged commit 0bc09da into develop Nov 18, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 18, 2026
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

80% Progress: 80% size: S Label to indicate a task of size S state:verified The change has passed Copilot verification.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🔧🧑‍💻 - Lock remaining installed workflow action dependencies

2 participants