Skip to content

Run ha-ui validation on self-hosted runners - #25

Merged
efraespada merged 4 commits into
developfrom
chore/24-run-ha-ui-validation-on-self-hosted-runners
Nov 12, 2026
Merged

efraespada merged 4 commits into
developfrom
chore/24-run-ha-ui-validation-on-self-hosted-runners

Conversation

@efraespada

@efraespada efraespada commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Repository validation and npm candidate lookup now use organization self-hosted runners, with CI and Storybook checks isolated in a pinned Linux ARM64 Playwright container. GitHub-hosted runners remain responsible for npm publishing and Pages deployment, preserving their OIDC-based publishing flow.

What changed

  • Added a shared containerized validation script that checks the pinned Node and pnpm versions and runs the quality, package provenance, SSR, Storybook, and browser checks.
  • Moved CI Check and the Storybook Pages build to the organization's Apple Silicon runner group; Linux ARM64 Docker isolation preserves the pinned Playwright environment.
  • Moved npm candidate lookup to the organization's Linux runner group while keeping npm publishing and Pages deployment on GitHub-hosted runners.
  • Updated delivery documentation and architecture checks for branch-push CI and runner routing.

Validation

  • Author reports all 13 architecture tests passed locally.
  • Author reports the Pages container completed the 1,475-test suite, five compiled consumers, SSR, Chromium, Firefox, WebKit, and all 10 static catalog tests.

Closes #24

@docs-page

docs-page Bot commented Nov 12, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/ha-ui~25

Documentation is deployed and generated using docs.page

@vypbot vypbot added the size: L Label to indicate a task of size L label Nov 12, 2026
@vypbot

vypbot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: db4319338809; base: c916b012217e; reason: protected-path.

@vypbot vypbot added 65% Progress: 65% state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 12, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on db43193. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 09e877c was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • high: Fork PRs can bypass the self-hosted runner guard — .github/workflows/ci_check.yml:16

Comment thread .github/workflows/ci_check.yml Resolved
@vypbot

vypbot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on db43193.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. 50% Progress: 50% and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. 65% Progress: 65% labels Nov 12, 2026
@vypbot vypbot added 45% Progress: 45% state:ai-processing A Copilot agent is analyzing or working on the issue or change. state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed 50% Progress: 50% state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 12, 2026
@efraespada
efraespada merged commit a6d6a69 into develop Nov 12, 2026
9 checks passed
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

45% Progress: 45% size: L Label to indicate a task of size L state:verified The change has passed Copilot verification.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants