Repository navigation
feat(automation): review previous manual runs - #123
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled onb3f1434. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit e68c173 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Clear history when membership access changes —
frontend/src/application/automation-run-history.ts:46
Bugbot: review complete
|
Installed Edge.39 qualificationHome Assistant Supervisor installed In the dedicated Domus Chrome group, an English keyboard journey opened the empty history and ran saved revision 1 at low stock to create the synthetic task. Stock intake brought the product to the minimum. A second run recorded a no-task result. In the Spanish 390-pixel view, the two entries showed recorded times and revision 1, in commit order. Only the matching run linked to the exact original task, which opened from history. Disabling the rule preserved both entries. The temporary app, its private data and its repository source were removed. All eight pre-existing repository entries, including the four Domus sources, were verified afterward. Local source verification passed 5,447 backend tests and 1,775 frontend tests with 100% supported coverage, plus 111 compiled Chromium journeys. The current UI checksum baseline matches both the pinned container and the built wheel. The historical checksum entries retain their original source identities. |
Edge.40 qualification after the authorization fixHome Assistant Supervisor installed version A fresh synthetic household verified the initial empty history by keyboard in English, one result that created a task, and a later no-task result after intake reached the stock minimum. The Spanish 390-pixel view displayed both original times and revision 1, provided one link, and opened the exact task. A read-only administration refresh retired the open history. Reopening the rule and reading it again returned both original entries. Actual permission revocation and cancellation of an in-flight prior page were checked in the protected backend fixtures and Chromium regression tests. The temporary Home Assistant app, its private data, and its source were removed. The eight pre-existing repository entries, including four Domus sources, were verified afterward. The corrected frontend passed 1,776 tests at 100% for all four supported metrics by file. Both compiled history journeys passed on the final runtime source, along with all nine app and wheel package assertions. |
Closes #122.
From a saved rule in Household, a member can now reopen their own manual runs, page through older results, and follow the exact authorized task. Original revisions and stock decisions survive edits, disablement and restoration. Retained results remain visible without a live task link. History uses existing schema 33 receipts.
docs/evidence/automation-run-history-qualification.md.Local verification includes 1,775 frontend tests with complete per-file coverage, 111 compiled Chromium journeys across both compositions, eight packaging checks, and the ARM64 candidate's installed file hashes, native launcher and standalone listener. Edge.39 pins runtime
eba168e88dedd7ddd6f84ea712094ca464a76f27. The exact-head CI and the temporary Home Assistant qualification will be linked here when complete.