Skip to content

feat(automation): review previous manual runs - #123

Merged
efraespada merged 6 commits into
developfrom
feature/122-review-previous-manual-automation-runs
Nov 18, 2026
Merged

efraespada merged 6 commits into
developfrom
feature/122-review-previous-manual-automation-runs

Conversation

@efraespada

@efraespada efraespada commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Closes #122.

From a saved rule in Household, a member can now reopen their own manual runs, page through older results, and follow the exact authorized task. Original revisions and stock decisions survive edits, disablement and restoration. Retained results remain visible without a live task link. History uses existing schema 33 receipts.

  • Binds every read and cursor to current installation, channel, household, invoking member and selected rule.
  • Provides bounded recent and older pages, retry after a failed read, and recovery from an expired cursor in English and Spanish.
  • Publishes the shared Ingress and standalone contract and the eight SDD cases in docs/evidence/automation-run-history-qualification.md.

Local verification includes 1,775 frontend tests with complete per-file coverage, 111 compiled Chromium journeys across both compositions, eight packaging checks, and the ARM64 candidate's installed file hashes, native launcher and standalone listener. Edge.39 pins runtime eba168e88dedd7ddd6f84ea712094ca464a76f27. The exact-head CI and the temporary Home Assistant qualification will be linked here when complete.

@docs-page

docs-page Bot commented Nov 18, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/domus~123

Documentation is deployed and generated using docs.page

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 18, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on b3f1434. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit e68c173 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Clear history when membership access changes — frontend/src/application/automation-run-history.ts:46

@vypbot

vypbot commented Nov 18, 2026 •

Copy link
Copy Markdown

Bugbot: review complete

Current status: No active findings on b3f1434.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. size: XXL Label to indicate a task of size XXL and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Installed Edge.39 qualification

Home Assistant Supervisor installed 0.0.0-edge.39 from this PR's temporary feature source. The package pins runtime eba168e88dedd7ddd6f84ea712094ca464a76f27, source archive b6164754b7c63e05ca4880974537f66d0ab4d86180b7a5c8cc88938c5ba247d6, and wheel e6e7a89e7845bcaeb1a6d7994e6041084343d7dc7fb765a60d8f6430c4df8bbb. The local ARM64 build matched the manifest for all 226 Python files and all four UI files. Its native and standalone smoke tests passed.

In the dedicated Domus Chrome group, an English keyboard journey opened the empty history and ran saved revision 1 at low stock to create the synthetic task. Stock intake brought the product to the minimum. A second run recorded a no-task result. In the Spanish 390-pixel view, the two entries showed recorded times and revision 1, in commit order. Only the matching run linked to the exact original task, which opened from history. Disabling the rule preserved both entries. The temporary app, its private data and its repository source were removed. All eight pre-existing repository entries, including the four Domus sources, were verified afterward.

Local source verification passed 5,447 backend tests and 1,775 frontend tests with 100% supported coverage, plus 111 compiled Chromium journeys. The current UI checksum baseline matches both the pinned container and the built wheel. The historical checksum entries retain their original source identities.

@vypbot vypbot added 80% Progress: 80% state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. state:reviewing A pull request is being reviewed. and removed state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. state:ai-processing A Copilot agent is analyzing or working on the issue or change. state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 18, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Edge.40 qualification after the authorization fix

Home Assistant Supervisor installed version 0.0.0-edge.40 from this PR's temporary source. It pins runtime 50aa7190e4d910c8bea5e35658314279db284e3b, source archive 3959dde1479d90d3d6ddcb1489742ed998d6b47fcccc7daeba1fe1a3f324b987, and wheel a75cb57fd5e309a11bc26aeb33446b4ee5e78b63bdcc569423176cb6ebd1f716. The pinned ARM64 image verified all 226 Python files, four UI files, native launcher, and standalone listener.

A fresh synthetic household verified the initial empty history by keyboard in English, one result that created a task, and a later no-task result after intake reached the stock minimum. The Spanish 390-pixel view displayed both original times and revision 1, provided one link, and opened the exact task. A read-only administration refresh retired the open history. Reopening the rule and reading it again returned both original entries. Actual permission revocation and cancellation of an in-flight prior page were checked in the protected backend fixtures and Chromium regression tests. The temporary Home Assistant app, its private data, and its source were removed. The eight pre-existing repository entries, including four Domus sources, were verified afterward.

The corrected frontend passed 1,776 tests at 100% for all four supported metrics by file. Both compiled history journeys passed on the final runtime source, along with all nine app and wheel package assertions.

@efraespada
efraespada merged commit c2b133c into develop Nov 18, 2026
19 checks passed
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:reviewing A pull request is being reviewed. labels Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

80% Progress: 80% size: XXL Label to indicate a task of size XXL state:verified The change has passed Copilot verification.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants