Skip to content

feat: Save and reopen household automation drafts (#118) - #119

Merged
efraespada merged 14 commits into
developfrom
feature/118-save-and-reopen-household-automation-drafts
Nov 18, 2026
Merged

efraespada merged 14 commits into
developfrom
feature/118-save-and-reopen-household-automation-drafts

Conversation

@efraespada

@efraespada efraespada commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add protected listing, reopening and saving of inactive manual task rules in Household settings.
  • Keep immutable revisions with optimistic concurrency and recover the original save by its idempotency key. The audit envelope is acknowledged in the save transaction and never appears in the pending outbox.
  • Preserve the exact version-one definition and migrate representative schema 20 and 31 data to schema 32. Version-one grouped conditions can be reopened and previewed as saved.

Closes #118. See the automation draft qualification for requirements and case evidence.

Verification

  • Backend suite: 5,377 tests, 100% coverage with branches. Migration, rollback, restart and restored original receipts exercised with the full schema 20 fixture and a schema 31 export produced by the pinned Edge.32 runtime.
  • Frontend suite: 1,761 tests, 100% statement, branch, function and line coverage. Compiled browser journeys passed in Ingress and standalone with English desktop keyboard and Spanish narrow touch, including original-save recovery after page reload and explicit conflict resolution.
  • Python tooling, application import contracts, types, formatting and local documentation links passed.
  • Installed Edge.33 verification covers the actual aarch64 Supervisor app, the Ingress rule journey and scoped cleanup.
  • The self-hosted browser suite exercised both draft journeys. One administration race returned storage_busy during the follow-up authorization read. The revised case verifies the resulting refresh path and still requires a single durable write.

@docs-page

docs-page Bot commented Nov 18, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/domus~119

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XXL Label to indicate a task of size XXL state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@vypbot vypbot changed the title Save and reopen household automation drafts feat: Save and reopen household automation drafts (#118) Nov 18, 2026
@vypbot
vypbot self-requested a review November 18, 2026 01:35
@vypbot vypbot added this to vypdev Nov 18, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 18, 2026
@vypbot
vypbot changed the base branch from develop to master November 18, 2026 01:35
@efraespada efraespada linked an issue Nov 18, 2026 that may be closed by this pull request
1 of 6 tasks
@vypbot
vypbot changed the base branch from master to develop November 18, 2026 01:36
@vypbot vypbot added state:reviewing A pull request is being reviewed. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Installed Edge.33 acceptance

On November 18, 2026, Home Assistant Supervisor built and installed 0.0.0-edge.33 as the disposable aarch64 app 5194b735_domus_edge from this PR's managed branch. The package pins runtime 84f52d9c470db79a2f1e5818e8837c4b01e9799d and SQLite schema 32. The installed file inventory matches the exact CI wheel, and the local pinned image passed native and standalone package checks.

In Chrome through native Ingress, I created a synthetic household and product, saved an inactive rule with its stock condition using the keyboard in English, reloaded Ingress and reopened the exact title and condition. I switched to Spanish, previewed the saved rule and saved revision 2 with a changed title. The rule remained inactive and the Tasks view remained empty.

Supervisor confirmed removal of the disposable app and its private data folder. I removed its exact repository source and confirmed the other four Domus source entries remained present.

@vypbot vypbot added the 80% Progress: 80% label Nov 18, 2026
@efraespada
efraespada marked this pull request as ready for review November 18, 2026 01:59
@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 18, 2026
@vypbot

vypbot commented Nov 18, 2026 •

Copy link
Copy Markdown

Bugbot: review complete

Current status: No active findings on bb38d2d.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:reviewing A pull request is being reviewed. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@vypbot vypbot removed the 80% Progress: 80% label Nov 18, 2026
@vypbot vypbot added the 80% Progress: 80% label Nov 18, 2026
@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 18, 2026
@vypbot vypbot added state:reviewing A pull request is being reviewed. and removed state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. labels Nov 18, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Verified a fresh Domus Edge 0.0.0-edge.36 install in Home Assistant Supervisor (aarch64), using the managed branch and the immutable runtime source 3f7bf3543db895213362ff24efab28908e864828. PR head bf1e10206bff810f15de64f41b9fd2cbd178dfc2 includes that same package and synchronizes the current-build asset receipt consumed by CI.

  • Entered a synthetic household through Ingress, saved a manual draft using the keyboard, reloaded and reopened the inactive revision, and confirmed the exact title and editable field with the UI in Spanish. Tasks remained empty.
  • The delayed open and failed-then-delayed journal recovery also passed against the compiled production bundle in standalone and Ingress. All 1,762 frontend tests and all four 100% coverage metrics passed.
  • Verified 223 backend files and all four production UI files against the aarch64 image and wheel. Local package/asset-license verification and pinned image checks passed.
  • Removed the temporary Supervisor app, its private test data and its temporary repository registration. The four existing Domus repository entries remained present.

@vypbot vypbot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on bb38d2d. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 2 potential problems when commit bf1e102 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.

Findings

  • low: Generated capability path count is stale — specs/catalog.json:1013
  • low: A failed conflict review hides its retry action — frontend/src/application/automation-drafts.ts:199

Comment thread specs/catalog.json Resolved
@vypbot vypbot added state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. and removed state:reviewing A pull request is being reviewed. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 18, 2026
@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 18, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Verified the installed Domus Edge 0.0.0-edge.37 candidate on Home Assistant Supervisor (aarch64). PR head bb38d2d6745e20a0093c06a57563fc832b661a56 pins runtime source 63890ace59d55ec76e0b9c3c7c832598eeeab7a1. The local aarch64 image and wheel matched all 223 backend modules and all four production UI assets. Package/license and pinned native/standalone smoke tests passed.

  • Used a fresh household and two Chrome tabs to create an inactive draft, save revision 2 in one tab and reproduce a stale save conflict in the other.
  • Temporarily blocked only the draft GET route in the stale test tab. The failed comparison retained the local title and its retry action, and promptly kept Save draft disabled.
  • Cleared the temporary browser block, retried with the keyboard, reviewed revision 2 and retained the local edit. Successfully saved inactive revision 3. Tasks stayed empty.
  • Removed the disposable app, private test data and temporary repository registration. The four existing Domus sources remained present.

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. 55% Progress: 55% and removed state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. state:ai-processing A Copilot agent is analyzing or working on the issue or change. 80% Progress: 80% labels Nov 18, 2026
@efraespada
efraespada merged commit 54b2073 into develop Nov 18, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 18, 2026
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

55% Progress: 55% size: XXL Label to indicate a task of size XXL state:verified The change has passed Copilot verification.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

✨🧑‍💻 - Save and reopen household automation drafts

2 participants