Skip to content

fix: Recover a uniquely identifiable accepted Bugbot status dispatch without a returned run ID (#976) - #989

Open
efraespada wants to merge 1 commit into
developfrom
bugfix/976-recover-a-uniquely-identifiable-accepted-bugbot-status-dispatch-without-a-returned-run-id
Open

efraespada wants to merge 1 commit into
developfrom
bugfix/976-recover-a-uniquely-identifiable-accepted-bugbot-status-dispatch-without-a-returned-run-id

Conversation

@efraespada

@efraespada efraespada commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Accepted status-card dispatches without a returned run ID can now recover one exact matching worker run. This lets publication acknowledgment complete safely while preserving existing identity checks and fallback behavior when recovery is unresolved.

What changed

  • Correlate each dispatch to the exact handoff bytes; include the progress observation sequence so new progress remains distinct.
  • Recover an accepted dispatch only when complete listings identify one matching repository, workflow, ref, operation, and attempt.
  • Retain accepted operation state and share acknowledgment retries without issuing another dispatch POST.
  • Reject invalid worker correlation before provider reads and retain existing publication checks; unresolved acknowledgment preserves the verified card and Check fallback without issuing a completed receipt.
  • Document the recovery bounds, retry guidance, and limitation that correlation does not attest producer code.

Validation

  • Five focused dispatch, worker, handoff, publication, and policy suites passed: 62 tests.
  • Typecheck, workflow and documentation/specification checks, matching Action bundle, and Graphify passed.
  • Installed hook passed build, 943 Jest suites (18,715 tests; 35 existing skips), and lint.

Review notes

Closes #976

…patch-without-a-returned-run-id: recover correlated accepted status dispatch acknowledgments (#976)
@docs-page

docs-page Bot commented Nov 19, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~989

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Recover exact accepted status dispatch acknowledgments (#976) fix: Recover a uniquely identifiable accepted Bugbot status dispatch without a returned run ID (#976) Nov 19, 2026
@vypbot
vypbot self-requested a review November 19, 2026 19:28
@vypbot vypbot added this to vypdev Nov 19, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 19, 2026
@vypbot
vypbot changed the base branch from develop to master November 19, 2026 19:29
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 19, 2026
@vypbot
vypbot changed the base branch from master to develop November 19, 2026 19:29
@vypbot vypbot added the 60% Progress: 60% label Nov 19, 2026
@vypbot

vypbot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 1b02448.

Pull request · Verified commit · Current review checks · Workflow run

Implementation progress and pending work · 1b024481

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.67%. Comparing base (239a04f) to head (1b02448).
⚠️ Report is 291 commits behind head on develop.

Files with missing lines Patch % Lines
...github/github_bugbot_status_card_acknowledgment.ts 93.44% 1 Missing and 3 partials ⚠️
...cture/github/github_bugbot_status_card_dispatch.ts 88.88% 0 Missing and 1 partial ⚠️
...ucture/github/github_bugbot_status_card_handoff.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #989      +/-   ##
===========================================
+ Coverage    95.25%   95.67%   +0.41%     
===========================================
  Files         1172     1564     +392     
  Lines        39236    49201    +9965     
  Branches     11685    15371    +3686     
===========================================
+ Hits         37373    47071    +9698     
- Misses         698      793      +95     
- Partials      1165     1337     +172     
Files with missing lines Coverage Δ
src/actions/github_action.ts 85.09% <ø> (-10.78%) ⬇️
...cture/github/github_bugbot_status_card_workflow.ts 81.81% <100.00%> (ø)
...cture/github/github_bugbot_status_card_dispatch.ts 77.58% <88.88%> (ø)
...ucture/github/github_bugbot_status_card_handoff.ts 82.85% <75.00%> (ø)
...github/github_bugbot_status_card_acknowledgment.ts 93.44% <93.44%> (ø)

... and 317 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot

vypbot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 4/4 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 1b024481d9d8; base: ccefb27627cd; reason: protected-path.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

60% Progress: 60% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:awaiting-maintainer state:ready

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Recover a uniquely identifiable accepted Bugbot status dispatch without a returned run ID

3 participants