Skip to content

fix: bound native progress correction for repeated citations - #945

Merged
efraespada merged 3 commits into
developfrom
bugfix/944-repeated-native-citations-pass-the-assessment-schema-then-abort-same-head-progress
Nov 8, 2026
Merged

efraespada merged 3 commits into
developfrom
bugfix/944-repeated-native-citations-pass-the-assessment-schema-then-abort-same-head-progress

Conversation

@efraespada

@efraespada efraespada commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

A native progress assessment could pass its citation schema, then abort after complete source collection when a reference repeated. Repetition alone can now use the existing single complete-batch correction shared with length/completion recovery; every receipt and final freshness gate still applies. Closes #944.

What changed

  • Require distinct citations explicitly and preserve the full original scope, evidence dictionary, effective profile/schema, settings and bounds on correction. No deduplication, third query or partial publication.
  • Bind correction authority privately to the actual frozen current request. Forged, serialized, provider-thrown and older-invocation errors, invalid evidence and simultaneous semantic defects cannot allocate it. Persistent repetition is nonretryable.
  • Update the owning SDD, catalog, operator guidance and case budget, retaining all 85 original owner cases and adding 14 distinct declarations.

Validation

  • Genuine native-adapter pre-fix regressions in both profiles; 91 progress suites / 2,009 rows pass.
  • Full root: 921 suites / 18,313 passed, 35 pre-existing skips; all budgets pass. All six changed/new runtime modules: 100% statements, branches, functions and lines.
  • Extension: 385 suites / 5,289 passed, 100% of all four metrics. Setup ledger retains its 14 explicitly open human cases (336/350).
  • Types, lint, build, package/CLI/typed-API/web-session smoke, specifications, documentation and workflow contracts pass. Normal hook evidence and exact-head native review/CI, official changed-line coverage and real Domus candidate qualification are recorded before merge.
  • Native adapter replay preserves the unchanged original Domus body, 169 fixture requirements and 17 source parts; late-batch exhaustion and source drift cause zero publication writes.

Review notes

The original native rejected response was unavailable. Citation repetition is inferred from that failure path; the deterministic schema/receipt counterexample is separate direct evidence. Domus stable Commit 42518152136 remains a recorded failure; new qualification uses this corrected immutable source, not an unchanged-head rerun. Published 3.10.12 remains immutable, and this PR does not publish another version.

@docs-page

docs-page Bot commented Nov 8, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~945

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 8, 2026 21:51
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 8, 2026
@efraespada
efraespada marked this pull request as ready for review November 8, 2026 21:52
@vypbot vypbot added this to vypdev Nov 8, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 8, 2026
@vypbot

vypbot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: This pull request is outside the configured approval scope.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 5168c951343d; base: 13560d95ec64; reason: scope.

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 5168c95. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 89cf1a4 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Combined citation and completion defects are reported as citation exhaustion — src/application/policies/progress_batch_policy.ts:209

@vypbot

vypbot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 5168c95.

Pull request · Verified commit · Workflow run

@codecov-commenter

codecov-commenter commented Nov 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (239a04f) to head (5168c95).
⚠️ Report is 164 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #945      +/-   ##
===========================================
+ Coverage    95.25%   96.10%   +0.85%     
===========================================
  Files         1172     1528     +356     
  Lines        39236    47539    +8303     
  Branches     11685    14794    +3109     
===========================================
+ Hits         37373    45686    +8313     
+ Misses         698      697       -1     
+ Partials      1165     1156       -9     
Files with missing lines Coverage Δ
src/application/policies/progress_batch_policy.ts 100.00% <100.00%> (ø)
...tion/policies/progress_citation_recovery_policy.ts 100.00% <100.00%> (ø)
...cation/policies/progress_prompt_capacity_policy.ts 100.00% <100.00%> (ø)
...cation/usecases/actions/progress_batch_workflow.ts 100.00% <100.00%> (ø)
...ases/actions/query_progress_assessment_workflow.ts 100.00% <100.00%> (ø)
src/domain/progress_batch_diagnostic.ts 100.00% <ø> (ø)
src/domain/progress_citation_repetition.ts 100.00% <100.00%> (ø)

... and 197 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada

Copy link
Copy Markdown
Member Author

Exact-head verification for 5168c951343dbb57161a3c278eaf0ea00bffd51d, against develop 13560d95ec643171e9c87e8e262fc7a57bb2acbb.

  • CI and Linux, macOS and Windows passed. Native Review completed 2/2 partitions with no active findings and no unresolved threads. The earlier compound-defect classification finding was independently verified fixed.
  • The official Codecov head report was complete. Intersecting the actual develop diff with that report gives 77/77 covered lines, zero misses or partials. This is a per-line audit of the official report.
  • Domus PR #29 ran the exact SDK commit on consumer head 52a6a14f130b5665904bf708fdd0d40081ec85b6. Commit verified all 134 admitted requirements in 5/5 batches using 17 source parts. Review completed 42/42 partitions with zero active findings. Application CI passed for both actual image architectures. The complete Domus issue body and 29 protected resources were unchanged in the final qualification increment. The Domus PR remains open.
  • The real adapter/decoder test reproduces the duplicate-citation validation mismatch, with a distinct-citation control. Domus's original rejected model response was not retained, so the exact live payload cannot be attributed. The correction permits at most one complete same-profile replacement and retains the original receipt and freshness gates.

This source PR does not publish or change version 3.10.12.

@efraespada
efraespada merged commit 0f1fc94 into develop Nov 8, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants