Add Compio runtime for completion-based local I/O - #9253
Closed
gatesn wants to merge 6 commits into
Closed
Conversation
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
gatesn
added
the
action/bench-random-access
ChatGPT Codex Connector
github-actions
Bot
removed
the
action/bench-random-access
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
gatesn
added
the
action/bench-random-access
ChatGPT Codex Connector
github-actions
Bot
removed
the
action/bench-random-access
Merging this PR will degrade performance by 12.36%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Random Access 📖Vortex (geomean): no vortex data random-access / vortex-file-compressed / ns (no group data, 0↑ 0↓)
random-access / parquet / ns (0.991x ➖, 0↑ 0↓)
random-access / lance / ns (1.002x ➖, 0↑ 0↓)
|
Contributor
Author
|
Closing this draft in favor of restructuring Compio as a dedicated I/O backend rather than a universal Vortex executor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vortex-compiocrateVortexReadAtimplementation that reads directly into sealedByteBuffervaluesVORTEX_IO_RUNTIME=compioto the random-access benchmarkI/O behavior
On Linux, Compio uses io_uring when available and falls back to polling. The file reader currently uses buffered I/O rather than
O_DIRECT. On macOS, Compio uses its polling backend.Local benchmark signal
On macOS, two order-reversed runs showed Compio improving correlated random access by roughly 11–31%, while uniform random access was roughly 12–27% slower.
The random-access PR workflow temporarily sets
VORTEX_IO_RUNTIME=compioso the labeled Linux run exercises the io_uring path. The isolated CI override commit should be reverted before merge.Validation
cargo +nightly fmt --allcargo clippy --all-targets --all-featurescargo test -p vortex-buffer --all-featurescargo test -p vortex-compio --all-featurescargo test -p vortex-file --all-featurescargo test -p random-access-bench --all-featurescargo test -p vortex-bench --all-featuresyamllint --strict -c .yamllint.yaml .github/workflows/pr-bench-runner.ymlgit diff --check