Expression enum and Root variant - #9247
Open
mhk197 wants to merge 3 commits into
Open
Conversation
Expression as enum instead of struct
Expression as enum instead of structExpression enum and Root variant`
Expression enum and Root variant`Expression enum and Root variant
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
force-pushed
the
mk/root-expression
branch
from
August 6, 2026 19:23
8dc4b89 to
996a4e3
Compare
mhk197
marked this pull request as ready for review
August 6, 2026 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
RootanExpressionvariant instead of aScalarFnVTableimplementation.This is groundwork for lambdas and variables — those are also nodes whose dtype comes from the
scope rather than from their children, and they need the same treatment.
Rootis not a scalar function. Its dtype comes from the scope rather than from its children (it has no children) and it is not executable.This PR makes
Expressionan enum instead of a struct.Rootbecomes a variant, and upcomingLambdaandVariablebecome variants as well.