Skip to content

duckdb: don't panic on unsupported Value type - #9243

Open
myrrc wants to merge 1 commit into
developfrom
myrrc/duckdb-no-panic-on-value-convert
Open

duckdb: don't panic on unsupported Value type#9243
myrrc wants to merge 1 commit into
developfrom
myrrc/duckdb-no-panic-on-value-convert

Conversation

@myrrc

@myrrc myrrc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Now we return an error to the binder instead of panic!.

@myrrc myrrc added changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration labels Aug 6, 2026
@myrrc
myrrc enabled auto-merge (squash) August 6, 2026 15:07
Comment thread vortex-sqllogictest/src/duckdb.rs
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 1900 skipped benchmarks1


Comparing myrrc/duckdb-no-panic-on-value-convert (0376ca7) with develop (77e7bc2)2

Open in CodSpeed

Footnotes

  1. 1900 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (93058ba) during the generation of this report, so 77e7bc2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/duckdb-no-panic-on-value-convert branch from 933c39f to 0376ca7 Compare August 6, 2026 15:26
@myrrc
myrrc requested a review from robert3005 August 6, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants