Skip to content

duckdb: forbid pushdown of list_col in (item, NULL) - #9242

Open
myrrc wants to merge 2 commits into
developfrom
myrrc/duckdb-time-ns
Open

duckdb: forbid pushdown of list_col in (item, NULL)#9242
myrrc wants to merge 2 commits into
developfrom
myrrc/duckdb-time-ns

Conversation

@myrrc

@myrrc myrrc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

list_col in (item, NULL) returns NULL on non-match. list_contains returns false.
Also support TIME_NS literals.

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc added changelog/feature A new feature ext/duckdb Relates to the DuckDB integration labels Aug 6, 2026
@myrrc
myrrc enabled auto-merge (squash) August 6, 2026 14:55
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc changed the title duckdb: support TIME_NS duckdb: forbid pushdown of list_col in (item, NULL) Aug 6, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.75%

❌ 2 regressed benchmarks
✅ 1899 untouched benchmarks
⏩ 43 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decompress[u64, (1000, 16)] 64.6 µs 72.4 µs -10.84%
Simulation compress_fsst[(1000, 64, 8)] 1 ms 1.2 ms -10.65%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/duckdb-time-ns (db2b879) with develop (0053f78)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc added changelog/fix A bug fix and removed changelog/feature A new feature labels Aug 6, 2026
@robert3005

Copy link
Copy Markdown
Contributor

Can we instead rewrite the expression to check if values contain null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants