refactor(vortex-geo): generalize scalar function execution - #9215
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
HarukiMoriarty
force-pushed
the
nemo/geo-scalar-execution
branch
3 times, most recently
from
August 6, 2026 14:41
09f16ff to
bdcdde1
Compare
gatesn
approved these changes
Aug 6, 2026
HarukiMoriarty
force-pushed
the
nemo/geo-scalar-execution
branch
from
August 6, 2026 17:58
105be3e to
70ff267
Compare
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
HarukiMoriarty
force-pushed
the
nemo/geo-scalar-execution
branch
from
August 7, 2026 13:52
70ff267 to
faf33c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Native geometry scalar functions need consistent handling for constant operands, pairwise columns, null propagation, and all-null batches. Keeping those responsibilities in each function makes new unary and binary kernels harder to implement correctly.
What changes are included in this PR?
What APIs are changed? Are there any user-facing changes?
This is an internal vortex-geo refactor. Existing scalar function semantics remain unchanged.