Repository navigation
fix(pages): add Vary header to negotiated HTML responses - #723
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-app navigation can trigger a full page reload when a shared cache returns HTML instead of page data.
For example, opening
/blogdirectly returns HTML. Following an in-app link to/blogrequests the same URL withX-VoidPages: true, expecting JSON. If a cache returns the earlier HTML response, Void falls back to a full page load.Cause
HTML responses were missing
Vary: X-VoidPages, which tells caches that requests with and without this header receive different responses.JSON and streamed NDJSON responses already included it, but HTML and streamed HTML did not.
Fix
Move the existing Vary handling to a shared location so all four response formats include the header. Also cover pages rendered after an action.
Preserve existing Vary values without adding duplicates, and respect
Vary: *. Island pages remain unchanged because they always return HTML.