Repository navigation
fix(dev): load one better-auth module in the dev worker - #712
Merged
Merged
Conversation
The workerd dependency optimizer excluded void, so an app import of better-auth/api was prebundled while Void's runtime loaded the package from source. OAuth request state lives on a module-local ref, and getOAuthState() then missed the state the runtime set. Exclude better-auth in those environments as well. Co-authored-by: sayhola <sayhola@froq.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #686
Description
void_workerexcludedvoidfrom dependency optimization but notbetter-auth, so an app import ofbetter-auth/apiwas prebundled while the runtime loaded the package from source. OAuth request state lives on a module-local ref, sogetOAuthState()missed the state the runtime set. Workerd environments, includingvoid_worker, now excludebetter-authas well so both sides resolve to the same source module. Production bundling is unchanged. No new config flag.Test
{ same: false }vp test run packages/void/test/unit/plugin-better-auth-dev.test.ts packages/void/test/unit/plugin-dev-asset-routing.test.ts packages/void/test/unit/plugin-vite-environment.test.ts -t 'OAuth state|CommonJS dependencies|void/db driver'vp run --filter ./packages/void typecheck