Repository navigation
fix(sync): tighten Send and Sync contracts for locks and guards - #579
Closed
Natural-selection1 wants to merge 1 commit into
Closed
Natural-selection1 wants to merge 1 commit into
Natural-selection1 wants to merge 1 commit into
Conversation
A shared SpinLock can lend out a write guard that replaces its payload. Require T: Send + Sync when sharing SpinLock or ISpinLock, and require Send on the boxed AArch64 ISR handlers owned by the interrupt registry. Keep SpinLock and RwLock guards on the acquiring thread, including across RwLock upgrades and downgrades. Use the same NotThreadSafe marker for guards that restore IRQ, preemption, syscall or flash mutex state. IrqTrace in particular decrements the current CPU's IRQ nesting count on drop. Keep these context guards Sync so shared references can still be borrowed across threads.
Natural-selection1
marked this pull request as draft
November 19, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep SpinLock and RwLock guards on the acquiring thread, including across RwLock upgrades and downgrades. Use the same NotThreadSafe marker for guards that restore IRQ, preemption, syscall or flash mutex state. IrqTrace in particular decrements the current CPU's IRQ nesting count on drop.