types: find usages of methods on type aliases - #38
Merged
Merged
Conversation
go/types keeps receivers such as `type Builder = *aBuilder` as *types.Alias. parserMethod only unwrapped pointers and named types, so find-usages reported the definition and skipped every call site. Unwrap aliases before matching named types, and keep a same-object fallback for method uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go/typeskeeps receivers such astype Builder = *aBuilderas*types.Alias. Find-usages previously matched only pointers and named types, so LiteIDE/gotools types -usereported the definition and skipped every call site.orgType/parseNamed/parserMethodbefore matching the underlying named type, and keep a same-object fallback for method uses.Verification
go test -count=1 ./types/llgo/ssa.Builder.ChangeInterface; after the fix, both the definition andexpr.go:2079usage are reported.