Repository navigation
fix(core): parse grouped glyph scripts in linear time - #124
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the grouped-script regex with a forward scan that preserves existing code names, including empty, nested and mismatched delimiters. Collapse underscores before trimming so malformed glyphs cannot trigger repeated scans during cleanup.
Addresses code-scanning alert 4. Based directly on main; no changes from the method-table branch.
Evidence
npm test --workspace @cs-object/core,npm run typecheck --workspace @cs-object/core, andnpm run lint --workspace @cs-object/core. Lint retains three existing warnings and a Biome schema-version notice outside the changed files.npm run test:integration -- tests/integration/python-export-runtime-names.test.ts, all six tests, plus formatting andgit diff --check.Merge Danger
Door: two-way
Revert restores the prior implementation. No schema, dependency or public API changes.
Blast Radius: core
Glyph-derived code names used by JSON sheet conversion and Python export. Compatibility cases and existing export tests retain prior naming behavior.