Repository navigation
docs: close the 3.0.0 loose ends — a test, the notebook, C-99's wording, #237 - #302
Merged
Merged
Conversation
…ng, #237 Found by a falsification audit of "everything in this repo is done": - tests/test_reconciliation_scale.py asserted the retired 2.x rule (empty grids stay zero) through ReconciliationModule, over a selection that held no empty-grid draw, so it asserted nothing. It now checks the 3.0.0 rule (every draw sums to its country) on countries that do have such draws, and fails when the fill is disabled. - notebooks/03_reconciliation.ipynb never mentioned donor fill. It gains a short §4b showing a filled draw, and §2 says the all-zero edge is the low-level function's, not the module's. - C-99 said "verified (0 unplaced)". It now says that figure holds by construction, and that adoption in the forecast lane is still pending (views-datafactory#527, views-models#663). - GOVERNANCE.md: the conformance floor is not a safe dependency pin. Closes #237. No package code changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q77JMFJbxEabjGdAh8jHWA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loose ends from a falsification audit of "everything in this repo is done and published". No package code changes, so no release.
tests/test_reconciliation_scale.py: it asserted the old 2.x rule (empty grids stay zero) throughReconciliationModule, over countries with no empty-grid draw, so the assertion was empty. It now checks that every draw sums to its country, on the countries that actually have empty draws. It fails when the donor fill is disabled; I checked that with a mutation.notebooks/03_reconciliation.ipynb: a new §4b shows donor fill (filled_draws,METHOD_DONOR_FILL). §2 now says the all-zero edge belongs to the low-level function only. The whole notebook executes.GOVERNANCE.md: the conformance floor is not a safe dependency pin; floor at the release that introduced the behaviour you rely on. Closes CONFORMANCE_FLOOR reads as a safe dependency floor, but estimator semantics changed above it #237.Gate: ruff, format, mypy (also on 3.11), lint-imports, 100% coverage, validate_docs, check_doc_refs, check_arch_tree and the examples all pass.
Closes #237
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q77JMFJbxEabjGdAh8jHWA