fix(scan): include a source path on license findings - #340
Draft
vibgrate-team wants to merge 1 commit into
Draft
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
Declared licenses from a manifest or a LICENSE/NOTICE/COPYING file now carry a stable repo-relative path in scan JSON and SARIF. Text that does not parse as SPDX is reported at that path instead of being dropped, and the file body is not copied into the artifact. Fixes #213 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vg scanJSON and SARIF now include a stable source path for a declared license whenever the scan already has an evidence file.licensefield is recorded at that manifest (projects[].license.path, findinglocation).LICENSE/LICENCE/COPYING/NOTICEfile (fixed name order) is the evidence path.vibgrate/unparseable-license, at that path instead of being dropped. A parsed SPDX id is a note,vibgrate/license, at the same path.Related issues
Fixes #213
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
Verify with
pnpm test,pnpm lint, andpnpm typecheck.test/license-findings.test.tsscans a fixturepkg/LICENSEwhose body is not a SPDX expression and assertspkg/LICENSEappears on the project license, the JSON finding, and the SARIFartifactLocation.uri, and that the file body is absent from the artifact.