fix: stop scan and build on a truncated lockfile - #332
Closed
vibgrate-team wants to merge 1 commit into
Closed
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
A truncated or syntactically invalid lockfile used to be skipped, so vg scan and vg build could exit successfully with a partial dependency graph. Fail before source parse workers start. The error names the file and tells the user to regenerate it with their package manager, without including lockfile contents. Fixes #310 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vg scanandvg buildnow stop when a lockfile is truncated or not valid syntax, before a partial dependency graph is built and before source parse workers start.The error names the lockfile and tells you to regenerate it with your package manager. The message does not include lockfile contents. The process exits non-zero. A valid lockfile still scans and builds as before.
Fixes #310
Related issues
Fixes #310
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
The check runs at the start of
vg scan(before project scanners and the code map) and at the start of graph build (before source parse workers). Parser diagnostics are discarded so a lockfile cannot be echoed in the error.