fix: skip blank ignore and exclude patterns - #324
Closed
vibgrate-team wants to merge 1 commit into
Closed
vibgrate-team wants to merge 1 commit into
vibgrate-team wants to merge 1 commit into
Conversation
Empty and whitespace-only exclude values, config excludes, and ignore lines were compiled into a match-all rule, so vg build and vg scan walked nothing. Those entries are now skipped. A real pattern beside a blank one still applies. Fixes #279 Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: vibgrate-team <vibgrate-team@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vg buildandvg scantreated an empty or whitespace-only ignore or exclude pattern as a match for every path. A blank--excludevalue, a blankexcludeentry in project config, or a.gitignoreline that is only a carriage return made the walk skip the whole project, so the repo looked empty.Those entries are now skipped. A real pattern written next to a blank one still applies, on both the build discovery walk and the scan walk.
Related issues
Fixes #279
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
Blank patterns are dropped before they are compiled. Tests cover an empty exclude, a whitespace-only exclude, a carriage-return-only ignore file, and a real pattern beside a blank one, for both discovery and the scan walk.