You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Chapter 10 "Client-side web application using AngularJS." still refers to the old AngularJS (which is no longer actively developed). What about updating it to the new Angular? Would PRs be accepted to do it?
I see that in the step-9 directory there is a redeploy.sh script which deploys everything (including the web client app). However it is not clear to me how the client app (located in /step-9/src/main/resources/webroot) is being served.
On 29 Nov 2018, at 09:49, Francesco Borzì ***@***.***> wrote:
@jponge yes I was looking at that piece of code and I'm wondering where we are referencing the webroot directory? sorry I'm completely new to Vert.x
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
@jponge we could get rid of e2e directory and maybe also of the unit tests (*.spec.ts) since we don't really need it. Then I don't know what else we can remove. What do you say?
Activity
jponge commentedon Nov 20, 2018
Yes PRs are welcome!
FrancescoBorzi commentedon Nov 28, 2018
@jponge I started to have a look into this
I see that in the
step-9directory there is aredeploy.shscript which deploys everything (including the web client app). However it is not clear to me how the client app (located in/step-9/src/main/resources/webroot) is being served.jponge commentedon Nov 29, 2018
@FrancescoBorzi here https://github.com/vert-x3/vertx-guide-for-java-devs/blob/master/step-9/src/main/java/io/vertx/guides/wiki/http/HttpServerVerticle.java#L67
FrancescoBorzi commentedon Nov 29, 2018
@jponge yes I was looking at that piece of code and I'm wondering where we are referencing the
webrootdirectory? sorry I'm completely new to Vert.xjponge commentedon Nov 29, 2018
FrancescoBorzi commentedon Nov 29, 2018
ok, thanks a lot for your answer!
FrancescoBorzi commentedon Dec 1, 2018
@jponge what's the best way to enable CORS in step-9 ? I need it for development purposes
FrancescoBorzi commentedon Dec 2, 2018
@jponge I've finished implementing the demo app for
step-9.You can find the source code here: https://github.com/FrancescoBorzi/vertx-guide-client-app
I've tried to keep the behaviour, code and logic similar to the old app whenever possible.
Before I start editing the book chapter, I kindly ask you to review the code. If you think it's good enough, I'll start adjusting the book chapter.
jponge commentedon Dec 7, 2018
I am no modern Angular expert, so it looks good to me.
That's a lot of files, can't it be made smaller?
FrancescoBorzi commentedon Dec 7, 2018
@jponge we could get rid of
e2edirectory and maybe also of the unit tests (*.spec.ts) since we don't really need it. Then I don't know what else we can remove. What do you say?jponge commentedon Dec 10, 2018
The simpler, the better :-)