Skip to content

Causing Retain Cycle #95

Open
#107
Open
Causing Retain Cycle#95
#107

Description

@Hitarth-Meesho
Hitarth-Meesho
opened on Jun 24, 2025

@shobhitic @raghav39 @mujahid01ali @sreedeeppaul @erpankajpatel
VLViewController has strong reference of VLViewControllerLifeCycleDelegate please make it weak otherwise WebKit will keep doing network call in background.

Image Image

Activity

  1. Hitarth-Meesho commented on Jul 21, 2025

    @Hitarth-Meesho
    Hitarth-Meesho
    on Jul 21, 2025
    Author

    Any update on this ?

  2. shubhransh-gupta commented on Oct 10, 2026

    @shubhransh-gupta
    shubhransh-gupta
    on Oct 10, 2026

    I have submitted a PR addressing this retain cycle: #107.

    The fix:

    • Class-bounds protocol VLViewControllerLifeCycleDelegate: AnyObject.
    • Changes lifeCycleDelegate in VLViewController to a weak reference.
    • Changes verloopSDK in VLViewController to a weak reference to break the retain cycle with VerloopSDK.
    • Adds deinit cleanup for the webview view hierarchy in VLViewController.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions