Repository navigation
fix: isolate callback options in the processor cache - #723
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
Contributor
|
@peterolkhov is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two Streamdown instances with different callback options can reuse the same Markdown processor and render the first instance’s output. Include callback identity and its full option path in the cache key, separately from serialized option data.
Type of Change
Related Issues
No linked issue. Extends the function-identity cache isolation in #702 to callback-valued options.
Changes Made
Testing
pnpm testpasses all 1,991 tests. Package builds, the website build,pnpm check, all four CI exact-optional TypeScript checks, and both workflow action test suites pass on Node 24.15.0 / pnpm 10.30.3. Built-package SSR and React client streaming reproductions also pass. The final regression file fails seven tests on unchanged main and passes with this fix.Test Coverage
Both static and streaming rendering, remark/rehype plugin callbacks, remark-rehype handlers, callback paths, ordinary JSON data, and processor reuse with the same callback. No coverage percentage was measured.
Screenshots/Demos
The automated sibling-instance reproduction changes from
leftleftto the requestedleftrightoutput.Checklist
pnpm changeset)Changeset
Additional Notes
GPT-6.1 Sol (high) generated the patch and tests and ran the listed local checks. Agent self-review is complete and the commit has a verified GitHub signature. No human review is claimed.
The root
check-typescommand currently schedules no tasks; the CI’s explicit exact-optional compiler commands were run instead. An additional full-packagetsc -p tsconfig.jsoncheck reports 210 errors identical to unchanged main, with none in the modified files. No documentation/API change is needed.