fix: restore resilient dictionary and question lookups - #161
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dictionary outages were reported as missing words, and sequential question providers could exhaust the request deadline before reaching a working fallback. Add a bounded English Wiktionary fallback with source attribution, reserve time for later question providers, and allow matching Wikipedia summaries for entity questions. Existing successful dictionary and Search Assist responses retain priority.
Also restrict Search Assist preload URLs to HTTPS DuckDuckGo hosts, cap public-page redirect chains, and prevent invalid Wikipedia summary lengths from panicking. Document the browser requirement and provider limitations; raise the example/default question timeout to 15 seconds while honoring explicitly configured limits.
Validation: full Go race suite, go vet, build, and govulncheck passed. Live deployment-host tests returned definitions for Linux, hello, and resilient, plus answers to Linux, Arch Linux, Debian, and sky-color questions. Third-party availability remains best-effort. Opt-in live tests are separate from deterministic CI.