fix: drop empty-value sshCommand/askPass overrides that git executes - #5
Merged
Conversation
Setting core.sshCommand and core.askPass to the empty string does not disable them — git tries to EXECUTE the empty value and dies with "cannot run : No such file or directory", breaking fetch entirely. Caught in end-to-end verification against the published policy before rollout. credential.helper= is different and is kept: an empty value is the documented way to reset the helper list. fsmonitor, hooksPath, protocol.ext and packObjectsHook overrides are unaffected and still neutralize the execution vectors they were added for. Assisted-by: AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4, caught in end-to-end verification against the published policy before rolling out to consumers.
Setting
core.sshCommandandcore.askPassto the empty string does not disable them — git tries to EXECUTE the empty value:That broke
fetchentirely, so a fresh install could not bootstrap at all.credential.helper=is kept: an empty value is the documented way to reset the helper list, and it verifies clean.The
core.fsmonitor,core.hooksPath,protocol.ext.allowanduploadpack.packObjectsHookoverrides are unaffected and still neutralize the execution vectors #4 added them for — re-verified by plantingcore.fsmonitorand confirming it never fires.Assisted-by: AI