Repository navigation
Sync tooling with agentic-monorepo-starter - #28
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pnpm 12 reads only auth settings from .npmrc, so save-exact there had no effect; saveExact in pnpm-workspace.yaml replaces it. engineStrict makes a dependency whose engines exclude the running Node.js fail the install, and the pnpm engines entry goes, since packageManager pins pnpm already. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copied from agentic-monorepo-starter: pre-commit runs format:check, lint and a staged gitleaks scan that fails closed, pre-push runs typecheck, test and knip. The prepare script enables them on install, and the Claude settings deny --no-verify. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
.nvmrc moves to 26.12.1 and @types/node to 26.6.5, matching agentic-monorepo-starter. engines.node still accepts 24.22.1. The Workers' runtime is set by compatibility_date and nodejs_compat in wrangler.jsonc, not by .nvmrc, so those stay as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The exact versions live in .nvmrc and packageManager, which the update PRs bump without touching the docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this repo's tooling in line with
valuecodes/agentic-monorepo-starter: the maintain-kit updates workflow, pnpm settings inpnpm-workspace.yamlwithengineStrict, the starter's git hooks, and Node.js 26. No app code changes.Add the maintain-kit updates workflow
.github/workflows/maintain-kit-updates.ymlis the starter's file, unchanged. Every week it callsupdates.ymlfromvaluecodes/maintain-kitand keeps one PR open per update kind (Node.js, pnpm,catalog:) on amaintain-kit/<kind>branch, for updates on the current major only. Nothing auto-merges. It pins the same maintain-kit commit (e5bf1d2, v1.0.0) as the dashboard, secret-scan and workflow-lint callers. AGENTS.md describes it, using the starter's wording, and README adds the repo setting it needs. workflow-lint inchecks.ymlalready covers the new file.Move pnpm settings to
pnpm-workspace.yamland enforce engines.npmrcis deleted. It held onlysave-prefix=andsave-exact=true, and pnpm 12 reads only auth settings from.npmrc, so neither setting had any effect.pnpm-workspace.yamlgetssaveExact: trueandengineStrict: true, with the starter's comments and placement.engineStrictmakes the install fail when a non-optional dependency's ownenginesexcludes the running Node.js, instead of only warning.engines.pnpmis removed frompackage.json.packageManageralready pins pnpm.engineStrictto the list of install guards.pnpm install --frozen-lockfile --forcepasses withengineStricton both Node.js 24.22.1 and 26.12.1.Add pre-commit and pre-push git hooks
.githooks/pre-commitand.githooks/pre-pushare the starter's files, unchanged (mode 755). pre-commit runsformat:check,lintandgitleaks git --staged. The scan fails closed, so a commit is refused when gitleaks is not installed. pre-push runstypecheck,testandknip. This repo already had all of those scripts.preparescript turns the hooks on duringpnpm install(git config --local core.hooksPath .githooks). Existing clones need onepnpm installorgit config core.hooksPath .githooks..claude/settings.jsondeniesgit commit --no-verify,git commit -nandgit push --no-verify.--no-verify. CI still scans the full history with the gitleaks version pinned in maintain-kit'ssecret-scan.yml. README now says how to install gitleaks for the hook, where it used to suggest running the scan by hand.Update Node.js to 26
.nvmrcis now26.12.1, and the@types/nodecatalog entry is now26.6.5(its comment now says the Node 26 line). The lockfile changes only for@types/node.engines.nodestays^24.22.1 || >=26.12.1, the same as the starter.migrations.ymlboth get Node.js through.github/actions/setup, which reads.nvmrc, so no workflow changes were needed. No other file outside the lockfile mentioned Node 24.compatibility_dateand thenodejs_compatflag in eachwrangler.jsonc, not from.nvmrc, so those stay as they are.Manual repo setting
Turn on Settings → Actions → General → "Allow GitHub Actions to create and approve pull requests", or the updates workflow cannot open its PRs. Those PRs are opened with
GITHUB_TOKEN, so theirpull_requestchecks wait until someone with write access clicks Approve workflows to run in the PR.Kept or skipped
@types/nodeentry inupdateConfig.ignoreDependenciesstays, so the type definitions still follow the.nvmrcmajor.NODE_VERSION/PNPM_VERSIONbuild variables after an update was left out. This repo deploys its Workers from GitHub Actions with wrangler, not through Cloudflare's build system.@types/node, andpackageManagerare left alone. The new updates workflow will propose those updates.Gates
I ran
pnpm typecheck,pnpm lint,pnpm knip,pnpm test,pnpm format:checkandpnpm buildbefore each commit. All of them passed, and they also passed on the base commit. Commits 1–3 ran on Node.js 24.22.1 and commit 4 on Node.js 26.12.1. The hooks ran on the last two commits.pnpm buildruns no tasks, because no workspace has abuildscript.🤖 Generated with Claude Code