Skip to content

Move to maintain-kit v1.0.0 and its secret-scan workflow - #55

Merged
valuecodes merged 1 commit into
mainfrom
feat/maintain-kit-v1
Oct 31, 2026
Merged

valuecodes merged 1 commit into
mainfrom
feat/maintain-kit-v1

Conversation

@valuecodes

Copy link
Copy Markdown
Owner

What

  • Re-pins the reusable workflows to valuecodes/maintain-kit v1.0.0 (e5bf1d2). The repo was renamed from valuecodes/automation, and GitHub does not redirect uses: references, so the scheduled dashboard and updates runs and the workflow-lint check fail until this merges.
  • Replaces the repo's own gitleaks job and .github/scripts/secrets-scan.sh with the new reusable secret-scan.yml: gitleaks at the version pinned in maintain-kit, over the full history. The check is now checks / secret-scan / gitleaks; pnpm secrets:scan is gone.
  • The pre-commit hook calls a local gitleaks (8.19+) directly on the staged diff and fails closed; the Docker fallback is gone. The README says how to install gitleaks.
  • The callers are renamed to maintain-kit-dashboard.yml and maintain-kit-updates.yml with job ids to match, so the runs read maintain-kit-dashboard / update-issue and maintain-kit-updates / <kind>.

After merging

  • Close the old dashboard issue Maintenance dashboard: 🔴 Security alert #50 (label maintenance-dashboard). The next run opens its replacement under maintain-kit-dashboard; pin that one. Maintenance dashboard: 🔴 Security alert #50 currently shows a security alert, which the replacement issue will list again if it still applies.
  • Update PRs will open on maintain-kit/<kind> branches with the maintain-kit-updates label. There are no open maintenance-updates/* PRs or branches to clean up.

How to test

pnpm format:check
pnpm lint
pnpm typecheck
pnpm knip
pnpm test

The pre-commit hook ran the new gitleaks line on the commit: no leaks found.

Security review

No security-impacting changes. The scan still runs on every PR and push, now through the pinned reusable workflow; the hook's gitleaks is whatever is installed locally, with CI as the gate.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 31, 2026 15:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T15:17:48.148993Z 85f2935 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@valuecodes
valuecodes merged commit d051c2e into main Oct 31, 2026
12 checks passed
@valuecodes
valuecodes deleted the feat/maintain-kit-v1 branch October 31, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants