You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Enable cross-platform dependency testing on Linux, macOS, and Windows - #454
Pull requests must include at least one of the required labels: internal (no release notes required), highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.
This PR enhances the CI workflow configuration and test file detection to improve cross-platform support and reliability:
The GitHub Actions workflow now runs on a matrix of operating systems (Linux, macOS, and Windows) instead of only Ubuntu. This change allows the tests to be executed on multiple platforms, increasing the robustness of the CI process.
A default shell (bash) is explicitly set for run commands, ensuring consistent script execution across different environments.
Specific steps in the workflow are now conditional based on the operating system. For example, the disk cleaning and Linux system dependency installation steps are executed only when the runner is Linux, while a separate step installs system dependencies on macOS using Homebrew.
The installation of build tooling has been simplified by switching from invoking shell scripts via curl to using pip to install Poetry and uv, which may simplify dependency management and improve security by reducing reliance on external scripts.
In the test discovery code, the relative path conversion now uses os.sep instead of a hardcoded '/' to construct module paths. This change ensures that test file detection works correctly on different platforms.
Test Suggestions
Verify the CI workflow runs successfully across all specified operating systems (Linux, macOS, and Windows).
Check that the conditional steps (disk cleaning, system dependency installation) are executed only on the intended platforms.
Confirm that the updated module path generation correctly identifies test files on both Windows and Unix-based systems.
Run integration tests to ensure that the changes in dependency installation via pip do not affect the build and packaging processes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internalNot to be externalized in the release notes
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amp-Thread-ID: https://ampcode.com/threads/T-ba360c9c-fe36-4892-8e6a-6890d566ed9c
Pull Request Description
What and why?
Add matrix testing for windows and macosx since our users are attempting to do this and getting issues.
How to test
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist