Repository navigation
[SC-18631] Present the PDF size limit as guidance across the PDF guides - #1542
Merged
Merged
Conversation
The 250 MB limit is enforced by the shared pdf-parse limits for every PDF workflow, including the Document Checker reading step, but the checker guide never said so. Adds one line to the reading callout, linking to the documented PDF requirements. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
emmavdh
force-pushed
the
emma/sc-18631/document-checker-pdf-limit
branch
from
October 2, 2026 17:27
1e72803 to
2b7ba8c
Compare
emmavdh
marked this pull request as ready for review
October 2, 2026 17:28
cachafla
approved these changes
Oct 2, 2026
emmavdh
changed the title
Per Juan: the figure is the backend default and deployments can set their own, so the Document Checker, document conversion and template outline pages now call it a recommended size and note that a deployment may enforce a different limit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
emmavdh
enabled auto-merge
October 2, 2026 18:04
Contributor
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
Contributor
Lighthouse check results✓ INFO: Average accessibility score is 0.93 (required: ≥0.9) — View the workflow run Audit mode: changed pages (1 URL(s)) Show Lighthouse scoresCommit SHA: ff494cc For a thorough audit, run the Lighthouse check workflow manually (Actions → Lighthouse check → Run workflow) with depth 0–2, or add the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Part of the Docs 26.10 tracker (sc-18631). The 250 MB figure in the docs is the backend's default pdf-parse cap (
utils/pdf_parse_limits.py), which self-hosted deployments can override, and in practice processing time depends more on page count and figures than on file size. Per Juan Martinez, present it as guidance rather than a hard limit, consistently everywhere PDFs are read.Changes:
guide/documentation/_check-documents.qmd: the Document Checker guide had no size guidance at all. The "first check reads the file" callout gains a bullet: keep PDFs under 250 MB as a guideline, a few hundred pages are supported, reading time grows with page count and figures, and a deployment may enforce a different limit.guide/templates/_create-document-templates.qmd(template outline from PDF) andguide/templates/manage-documents.qmd(PDF to document conversion): "Maximum size: 250 MB" becomes "Recommended size: under 250 MB", plus the deployment note.The matching 26.10 release note is adjusted in validmind/release-notes#169.
How to test
Preview (the preview site builds when the PR leaves draft; allow time for the deploy):
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
None (wording of an existing limit).
Checklist
🤖 Generated with Claude Code