Drop values-global.yaml keys that match framework defaults - #29
Open
cjeanner wants to merge 1 commit into
Open
Conversation
cjeanner
force-pushed
the
slim-values-global
branch
2 times, most recently
from
August 12, 2026 09:49
39dd93d to
72b65c6
Compare
cjeanner
marked this pull request as draft
August 12, 2026 12:51
Collaborator
Author
|
Draft: there seems to be weird things such as "there are default values, but they are actually mandatory" issues. Digging. |
values-global.yaml: remove secretLoader.disabled and multiSourceConfig.enabled block — both match clustergroup-chart and patterns-operator defaults. Keep syncPolicy and installPlanApproval (required by clustergroup JSON schema) and useCSV/secretStore.backend (override defaults). values-standalone.yaml: remove explicit namespace on rhoso-gitops application — defaults to the ArgoCD namespace via the clustergroup chart helper, which is correct for both single and dual ArgoCD modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cjeanner
force-pushed
the
slim-values-global
branch
from
August 12, 2026 13:11
72b65c6 to
f2fe89b
Compare
cjeanner
marked this pull request as ready for review
August 12, 2026 15:35
Collaborator
Author
|
Tested in my env: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
values-global.yaml: remove secretLoader.disabled and
multiSourceConfig.enabled block — both match clustergroup-chart and
patterns-operator defaults. Keep syncPolicy and installPlanApproval
(required by clustergroup JSON schema) and useCSV/secretStore.backend
(override defaults).
values-standalone.yaml: remove explicit namespace on rhoso-gitops
application — defaults to the ArgoCD namespace via the clustergroup
chart helper, which is correct for both single and dual ArgoCD modes.