Skip to content

CLA bot: broken document link, "reply" instructions that fail via GitHub's Reply button, and a missing signatures branch that blocks signing #1175

Closed

Description

@theredspoon

I found four issues while trying to sign the CLA on #1162 and #1169. Seems to be blocking #1162, #1166, and #1169.

1. Broken link in the "not signed" comment

custom-notsigned-prcomment uses $pathToCLADocument, but the action never substitutes it. At the pinned v2.6.1 tag, the only substitution ever applied to a custom comment is .replace('$you', you): https://github.com/contributor-assistant/github-action/blob/v2.6.1/src/pullrequest/pullRequestCommentContent.ts#L76. The $pathToCLADocument placeholder is copied from the action's own README, which documents it as if it works but never implements it: https://github.com/contributor-assistant/github-action/blob/v2.6.1/README.md#L137. Result, the bot posts the literal string instead of a working link: [contributor license agreement]($pathToCLADocument). Example: #1162 (comment). .github/CLA.md itself is fine and reachable directly, only the comment template is broken.

2. "Reply to this comment" fails silently when done literally

GitHub's own Reply button quotes the comment being replied to, producing a body like > [quoted text]\n\nI have read the CLA and I agree to it, not an exact match, so the issue_comment trigger silently skips it: https://github.com/vale-cli/vale/actions/runs/34076409285. The same exact-match check also rejects an otherwise-correct reply with a trailing period: https://github.com/vale-cli/vale/actions/runs/34077076206. Neither attempt gets any comment or feedback explaining the failure.

3. An exact match still fails, because the signatures branch doesn't exist

Posting the sentence exactly right triggered a failed run:

##[error]Error occurred when creating the signed contributors file: Branch cla-signatures not found. Make sure the branch where signatures are stored is NOT protected.
##[error]Committers of pull request 1169 have to sign the CLA

Run: https://github.com/vale-cli/vale/actions/runs/34077331382/job/101605911144. The workflow's own comment says this branch "must exist and must not be protected," a precondition that was never set up, and the action doesn't create it automatically. The missing branch is a repo-wide resource, not scoped to a PR, so this likely affects any contributor outside the jdkato,bot* allowlist, though I've only tested my own attempts here.

4. That same run also edited the bot's comment to claim success before the failure above happened

The comment now reads "The license agreement is signed": #1169 (comment) (created_at 01:43:38, updated_at 02:45:22, edited in place, not a new comment). The action edits the comment first (updateComment in https://github.com/contributor-assistant/github-action/blob/v2.6.1/src/pullrequest/pullRequestComment.ts#L26-L32), then attempts the actual signature write second (updateFile in https://github.com/contributor-assistant/github-action/blob/v2.6.1/src/setupClaCheck.ts#L33-L40), both inside one try/catch with no rollback. So the same run in point 3 both proved the persistence write fails and left the comment thread claiming it succeeded. The PR's real cla status check is unaffected and still shows failure from an earlier, separate run: https://github.com/vale-cli/vale/actions/runs/34073937565/job/101596337623. There's also an open upstream issue matching the same failure precondition: contributor-assistant/github-action#165.

Activity

  1. changed the title [-]CLA bot's "not signed" comment posts a literal $pathToCLADocument instead of the actual link[/-] [+]CLA bot: broken document link, and "reply" instructions that fail via GitHub's Reply button[/+] on Sep 7, 2026
  2. changed the title [-]CLA bot: broken document link, and "reply" instructions that fail via GitHub's Reply button[/-] [+]CLA bot: broken document link, "reply" instructions that fail via GitHub's Reply button, and a missing signatures branch that blocks signing[/+] on Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions