Skip to content

ci: shard the L12 canaries - #226

Merged
alexgrozav merged 1 commit into
mainfrom
l12-canary-shards-uxf-899
Nov 20, 2026
Merged

alexgrozav merged 1 commit into
mainfrom
l12-canary-shards-uxf-899

Conversation

@alexgrozav

Copy link
Copy Markdown
Contributor

What changed

Canaries (L12-unwired-listener) ran at its ten-minute limit, and GitHub cancelled it on some PR runs. This PR runs both L12 canaries in two shards, as ADR-0052 already does for the browser canaries, and records the rule in ADR-0115. No framework's output changes.

Cause: the canary's own work, not the setup or the runner. The evidence:

  • Each L12 canary ran in one job of the whole corpus: 253 specs on six hydrate projects (React, Vue, Svelte, Solid, Solid 2, Angular). L12-unwired-listener removes every element listener on the cases whose specs act, and each of those specs waits out a 5 s timeout.
  • In the last 60 PR runs of ci.yml, its Canaries step took 470 to 516 s on 17 passes, and 524 to 540 s on the three runs GitHub cancelled at 600 s (44088058778, 44488125998, 44499940831). Setup takes about a minute. The time has been flat since the canary was added, so no PR caused it.
  • L12-client-text has the same cause, at 350 to 463 s on 20 passes.
  • The same corruption in the browser projects, L9-unwired-handler, runs in two shards of 202 to 347 s each.
  • The two L12 canaries were never sharded because the matrix test looked for shards only among canaries whose projects include browser. Both L12 canaries have only hydrate evidence.

Changes:

  • ci.yml and nightly.yml: L12-client-text and L12-unwired-listener run as shard: 1/2 and shard: 2/2. The matrix goes from 35 to 37 jobs. timeout-minutes: 10 stays, and there are no retries.
  • canaries.unit.test.ts: the shard rule now checks each entry's own canaries for browser or hydrate evidence, so an unsharded hydrate canary fails it. It also pins L12-unwired-listener to two shards, beside L8 and L10.
  • ADR-0115 amends ADR-0052, whose status line and index row now name it. The integration README says that hydrate canaries are sharded too.

Checks run locally:

  • The matrix test passes. With either L12 canary put back in one unsharded entry in both workflows, it fails with L12-<name>: expected 1 to be greater than or equal to 2. For L12-unwired-listener this was run with its toHaveLength(2) line taken out, so the rule itself catches it. main's version of the test passes the same revert.
  • On React alone, L12-unwired-listener was caught in 60.2 s for shard 1/2 and 54.5 s for shard 2/2. The whole corpus took 107.1 s. L12-client-text was caught in 46.2 s and 39.4 s.
  • With the L12-unwired-listener plugin changed to return the module unchanged, shard 1/2 exits 1 with NOT CAUGHT.
  • The harness project (702 tests), @unframework.dev/repo-tests (78 tests), pnpm format:check, oxlint on the test file and the integration package's check-types pass.

The expected CI time is about 4.5 minutes for each L12 shard's step. This PR changes ci.yml, so its own run includes every canary job.

Checklist

  • The title follows Conventional Commits, as in feat(web): sell the next framework on the homepage.
  • pnpm format:check, pnpm lint, pnpm check-types and pnpm test pass.
  • Changes to a published package: a changeset from pnpm changeset (see .changeset/README.md).
  • Homepage changes: pnpm build, then pnpm --filter web lighthouse, still scores at least 0.95 in every category.

The second item is unticked because only the narrower checks above ran locally. CI runs the full loop. No package or homepage changes.

Both L12 canaries ran in one job of the whole corpus, 253 specs on six hydrate projects, and L12-unwired-listener's step took 470 to 540 s of the job's 600. Run each in two shards, as ADR-0052 does for the browser canaries, and check the shard rule over each entry's own canaries, so a canary with hydrate evidence can't be left whole. ADR-0115 records the rule and amends ADR-0052.

Co-authored-by: multica-agent <github@multica.ai>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://l12-canary-shards-uxf-899.unframework.dev, https://l12-canary-shards-uxf-899-unframework.blue-water-0397.workers.dev (commit 189be65)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://da2dabdd.unframework.dev, https://da2dabdd-unframework.blue-water-0397.workers.dev 189be65 2026-11-19T13:32:35.000Z Visit the dashboard ↗

@github-actions

Copy link
Copy Markdown
Contributor

Visual report: ✓ passed

3 examples on 7 targets. Pixels: live, compared with the reference's capture in this run. Reference: vue. Commit 189be65.

Example react vue (reference) svelte solid angular qwik astro
examples/Buttons ✓ matched, 0 px ✓ published-reference ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px
examples/Card ✓ matched, 0 px ✓ published-reference ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px
examples/TextField ✓ matched, 0 px ✓ published-reference ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px ✓ matched, 0 px

The run uploaded the full report as the design-system-visual artefact, kept for 7 days. Download it, unzip it and open report.html.

@alexgrozav
alexgrozav marked this pull request as ready for review November 19, 2026 13:49
@alexgrozav
alexgrozav merged commit beb2bf9 into main Nov 20, 2026
72 checks passed
@alexgrozav
alexgrozav deleted the l12-canary-shards-uxf-899 branch November 20, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant