Repository navigation
ci: shard the L12 canaries - #226
Merged
Merged
Conversation
Both L12 canaries ran in one job of the whole corpus, 253 specs on six hydrate projects, and L12-unwired-listener's step took 470 to 540 s of the job's 600. Run each in two shards, as ADR-0052 does for the browser canaries, and check the shard rule over each entry's own canaries, so a canary with hydrate evidence can't be left whole. ADR-0115 records the rule and amends ADR-0052. Co-authored-by: multica-agent <github@multica.ai>
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://l12-canary-shards-uxf-899.unframework.dev, https://l12-canary-shards-uxf-899-unframework.blue-water-0397.workers.dev (commit 189be65)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
Visual report: ✓ passed3 examples on 7 targets. Pixels:
The run uploaded the full report as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Canaries (L12-unwired-listener)ran at its ten-minute limit, and GitHub cancelled it on some PR runs. This PR runs both L12 canaries in two shards, as ADR-0052 already does for the browser canaries, and records the rule in ADR-0115. No framework's output changes.Cause: the canary's own work, not the setup or the runner. The evidence:
L12-unwired-listenerremoves every element listener on the cases whose specs act, and each of those specs waits out a 5 s timeout.ci.yml, itsCanariesstep took 470 to 516 s on 17 passes, and 524 to 540 s on the three runs GitHub cancelled at 600 s (44088058778, 44488125998, 44499940831). Setup takes about a minute. The time has been flat since the canary was added, so no PR caused it.L12-client-texthas the same cause, at 350 to 463 s on 20 passes.L9-unwired-handler, runs in two shards of 202 to 347 s each.browser. Both L12 canaries have onlyhydrateevidence.Changes:
ci.ymlandnightly.yml:L12-client-textandL12-unwired-listenerrun asshard: 1/2andshard: 2/2. The matrix goes from 35 to 37 jobs.timeout-minutes: 10stays, and there are no retries.canaries.unit.test.ts: the shard rule now checks each entry's own canaries forbrowserorhydrateevidence, so an unsharded hydrate canary fails it. It also pinsL12-unwired-listenerto two shards, beside L8 and L10.Checks run locally:
L12-<name>: expected 1 to be greater than or equal to 2. ForL12-unwired-listenerthis was run with itstoHaveLength(2)line taken out, so the rule itself catches it.main's version of the test passes the same revert.L12-unwired-listenerwas caught in 60.2 s for shard 1/2 and 54.5 s for shard 2/2. The whole corpus took 107.1 s.L12-client-textwas caught in 46.2 s and 39.4 s.L12-unwired-listenerplugin changed to return the module unchanged, shard 1/2 exits 1 withNOT CAUGHT.@unframework.dev/repo-tests(78 tests),pnpm format:check, oxlint on the test file and the integration package'scheck-typespass.The expected CI time is about 4.5 minutes for each L12 shard's step. This PR changes
ci.yml, so its own run includes every canary job.Checklist
feat(web): sell the next framework on the homepage.pnpm format:check,pnpm lint,pnpm check-typesandpnpm testpass.pnpm changeset(see.changeset/README.md).pnpm build, thenpnpm --filter web lighthouse, still scores at least 0.95 in every category.The second item is unticked because only the narrower checks above ran locally. CI runs the full loop. No package or homepage changes.