Repository navigation
chore(deps): use @uxfront/layer-docs 0.8.4's menu toggle and code themes - #85
Merged
Merged
Conversation
@uxfront/layer-docs 0.8.4 names Docus's mobile menu toggle, sets GitHub's high-contrast code themes and drops the wordmark's aria-label, so the site's own IconMenuToggle.vue and highlight theme go. AGENTS.md and CONTRIBUTING say the layer does both now. The release and the @uxfront/ui and @uxfront/scene versions it brings are excluded from pnpm's minimum release age until they age in. Co-authored-by: multica-agent <github@multica.ai>
alexgrozav
marked this pull request as ready for review
November 16, 2026 22:02
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://layer-docs-toggle-uxf-819.opencomponents.dev, https://layer-docs-toggle-uxf-819-opencomponents.blue-water-0397.workers.dev (commit cb8b73b)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The docs move to
@uxfront/layer-docs0.8.4, which now ships the two fixes this site kept its own copies of. So the copies go:app/components/IconMenuToggle.vueis deleted. The layer's toggle replaces Docus's in the same way, and it's named "Open menu" or "Close menu".content.build.markdown.highlight.themeblock is gone fromnuxt.config.ts. The layer sets the same GitHub high-contrast themes, with all three keys.AGENTS.mdand the "Keeping 100s" section of.github/CONTRIBUTING.mdnow say that the layer does both, and how to switch the code theme.0.8.4 also drops the wordmark link's
aria-label, so the link's name is its visible text. On this site it changes from "Open Components" to "OpenComponents", which fixes Lighthouse'slabel-content-name-mismatchon every docs page.@uxfront/layer-docs0.8.4 and the@uxfront/ui0.9.1 and@uxfront/scene0.5.1 it depends on were published less than 24 hours ago, so all three are inminimumReleaseAgeExcludeuntil they age in, as in #29. The site itself stays on@uxfront/ui0.6.0 and@uxfront/scene0.5.0. The layer only imports one icon from its own copy of@uxfront/ui.DocsPageHeaderLinks.vueandmodules/hydration-ids.tsstay.What I checked on the built site:
/docs/getting-started/introductionhas one<button aria-label="Open menu">, the header toggle. At phone size in Chrome, it takes focus with a visible ring, says "Close menu" once it's open and "Open menu" again once it's closed, and its lines don't animate underprefers-reduced-motion.--shiki-*token colour on the 88 built pages with highlighted code reaches 4.5:1 on the code block background, in light (lowest 4.83:1 on zinc 50) and dark mode (lowest 7.02:1 on zinc 800).aria-label, and its text is "OpenComponents".wrangler dev, mobile and desktop, on/docs/getting-started/introduction,/docs/components/button/uxand/docs/components/button/dx: Accessibility is 100 on all six runs.button-nameandcolor-contrastpass, andlabel-content-name-mismatchis "not applicable", since axe only tests a link whose name the page sets.Checklist
feat(docs): add the focus guideline.pnpm check-typespasses.pnpm dev. (Checked on the static build andwrangler devinstead. No page content changed.)pnpm build, thenpnpm lighthouse, still scores 100 in every category. (No homepage changes, but the dependency moved, so I ran it. Its assertions pass.)