Skip to content

render and check by slide id; rasterise and measure a snapshot unlocked - #9

Merged
uvrt merged 2 commits into
mainfrom
r3-render-ids-lock
Oct 10, 2026
Merged

uvrt merged 2 commits into
mainfrom
r3-render-ids-lock

Conversation

@uvrt

@uvrt uvrt commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Production feedback round 3, A2 and A6; handlers for uvrt/ooxml-edit#21.

  • A2: render/check slides take s:<id>, a $ref (resolved by the dispatcher) or a number from 1, also written "2" (what a strict decoder writes now that the items are strings). Images keep their slide 3 (s:257) labels; check lists its slides by id. A shape address or an unknown id is refused on slides[i] with the ids listed.
  • A6: render hands the worker the deck's bytes via call.run_unlocked; check opens a copy from the bytes and measures and validates it with the lock let go (outside a batch; snapshot open 15-30 ms against 175-380 ms of facts). Both cache under, and report, the snapshot's version. Warnings from opening the copy are swallowed (they were said at open).
  • Tests: render/check by id, number-as-string, ref after slides move, refusals; a render blocked in the pool while an edit completes and the render reports the version it drew. Budget-guard note updated (core 3,398 estimated, about 5,029 counted).
  • Needs ooxml-edit 0.14.0 (pin raised). CI temporarily installs ooxml-edit from r3-render-ids-lock (# TEMPORARY (r3)): after render/check: slide ids, and the slow part with the lock let go (0.14.0) ooxml-edit#21 merges, point it back at @main.

Merge order: uvrt/ooxml-edit#21 first, then this (after restoring the @main pin). Full suite locally: 2,273 passed. Repros: a2_render_by_id.py ok; a6_render_lock.py workers=2 edit during render 333 -> ~60 ms.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WCxhY1fvWQPiWCwz7SYUVh

uvrt and others added 2 commits October 10, 2026 23:55
slides takes s:<id>, $ref or a number. render hands the worker the deck's
bytes with the lock let go; check measures and validates a copy opened from
them. Both cache and report the snapshot's version. Needs ooxml-edit 0.14.0;
CI pins its branch temporarily (r3).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WCxhY1fvWQPiWCwz7SYUVh
@uvrt
uvrt merged commit ca02a7f into main Oct 10, 2026
19 checks passed
@uvrt
uvrt deleted the r3-render-ids-lock branch October 10, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant