Repository navigation
render and check by slide id; rasterise and measure a snapshot unlocked - #9
Merged
Merged
Conversation
slides takes s:<id>, $ref or a number. render hands the worker the deck's bytes with the lock let go; check measures and validates a copy opened from them. Both cache and report the snapshot's version. Needs ooxml-edit 0.14.0; CI pins its branch temporarily (r3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCxhY1fvWQPiWCwz7SYUVh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCxhY1fvWQPiWCwz7SYUVh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production feedback round 3, A2 and A6; handlers for uvrt/ooxml-edit#21.
render/checkslidestakes:<id>, a$ref(resolved by the dispatcher) or a number from 1, also written"2"(what a strict decoder writes now that the items are strings). Images keep theirslide 3 (s:257)labels;checklists its slides by id. A shape address or an unknown id is refused onslides[i]with the ids listed.renderhands the worker the deck's bytes viacall.run_unlocked;checkopens a copy from the bytes and measures and validates it with the lock let go (outside a batch; snapshot open 15-30 ms against 175-380 ms of facts). Both cache under, and report, the snapshot's version. Warnings from opening the copy are swallowed (they were said at open).r3-render-ids-lock(# TEMPORARY (r3)): after render/check: slide ids, and the slow part with the lock let go (0.14.0) ooxml-edit#21 merges, point it back at @main.Merge order: uvrt/ooxml-edit#21 first, then this (after restoring the @main pin). Full suite locally: 2,273 passed. Repros:
a2_render_by_id.pyok;a6_render_lock.pyworkers=2 edit during render 333 -> ~60 ms.🤖 Generated with Claude Code
https://claude.ai/code/session_01WCxhY1fvWQPiWCwz7SYUVh