Repository navigation
Conversation
Contributor
|
I'm not sure if we really want to support this. |
oech3
reviewed
Oct 18, 2026
| The utility can also be selected with `--coreutils-prog=UTIL`, including when | ||
| the binary is invoked under an unrecognized name. This supports script wrappers | ||
| that use the multi-call binary as their interpreter. | ||
|
|
Contributor
There was a problem hiding this comment.
I think we don't need to document this since this option is needed only for creating shebangs at build time.
limadog9
force-pushed
the
fix/coreutils-prog-option-9575
branch
from
October 18, 2026 17:36
fd3dbe1 to
e957d89
Compare
oech3
reviewed
Oct 18, 2026
| .into_owned() | ||
| .to_string_lossy(); | ||
| if get_utility_is_second_arg() { | ||
| name.strip_prefix("--coreutils-prog=") |
Contributor
There was a problem hiding this comment.
uucore can be used as a library. So this logic should be part of coreutils itself.
limadog9
force-pushed
the
fix/coreutils-prog-option-9575
branch
from
October 18, 2026 17:39
e957d89 to
71d7d8f
Compare
oech3
reviewed
Oct 18, 2026
|
|
||
| #[test] | ||
| #[cfg(all(unix, feature = "echo"))] | ||
| fn coreutils_prog_shebang() { |
Contributor
There was a problem hiding this comment.
Please remove this. This is just an usecase. Thus, this is duplicated test.
limadog9
force-pushed
the
fix/coreutils-prog-option-9575
branch
from
October 18, 2026 17:43
71d7d8f to
ab063ca
Compare
Accept --coreutils-prog=UTIL for explicit utility selection, including when the executable has an unrecognized name. Parse the option in the multicall entry point and provide the selected display name through a generic uucore override. Cover argument forwarding, exit status, invalid utilities, and aliases. Closes uutils#9575.
limadog9
force-pushed
the
fix/coreutils-prog-option-9575
branch
from
October 18, 2026 17:55
ab063ca to
5a943b1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support --coreutils-prog=UTIL when invoking the multicall binary, including under an unrecognized name or through a shebang wrapper. Help and diagnostics use the selected utility name.
Add coverage for argument forwarding, exit status, invalid utilities, aliases, and shebang execution. All 20 multicall tests pass.
Closes #9575.