Skip to content

stty: simplify import - #15383

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:stty-rfd
Oct 15, 2026
Merged

sylvestre merged 1 commit into
uutils:mainfrom
oech3:stty-rfd

Conversation

@oech3

@oech3 oech3 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@xtqqczze

Copy link
Copy Markdown
Collaborator

Needs to be rebased on 41f705b to compile.

@oech3

oech3 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

It is unrelated to passing CI.

@oech3

oech3 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

I agree with building package using translative dep is not ideal, but I don't think you shoud comment to all PRs if it is not actually broken. cargo build -p uu_stty is possible.

@xtqqczze

Copy link
Copy Markdown
Collaborator

cargo build -p uu_stty is possible.

That's my point though, it doesn't compile:

$ cargo build -q -p uu_stty
error[E0433]: cannot find `fs` in `rustix`
   --> src/uu/stty/src/stty.rs:195:47
    |
195 |                         .custom_flags(rustix::fs::OFlags::NONBLOCK.bits() as i32)
    |                                               ^^ could not find `fs` in `rustix`
    |
note: found an item that was configured out
   --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-1.1.5/src/lib.rs:223:9

@oech3

oech3 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

OK. I guess macos-latest CI was ignored when rustix::fs was introduced due to slow CI. But other platforms implicitly pulls it.

@xtqqczze

xtqqczze commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

OK. I guess macos-latest CI was ignored when rustix::fs was introduced due to slow CI. But other platforms implicitly pulls it.

Actually, it was failing to compile on all platforms. It seems we have no CI for non-multicall.

@oech3

oech3 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Locally, Linux is not affected.

@xtqqczze

Copy link
Copy Markdown
Collaborator

Interesting, it was failing for x86_64-linux-android.

@xtqqczze

Copy link
Copy Markdown
Collaborator

I like to verify locally with multiple targets at once, e.g.:

cargo check -q -p uu_stty --target aarch64-apple-darwin --target x86_64-linux-android

@sylvestre
sylvestre merged commit 4945ecf into uutils:main Oct 15, 2026
99 checks passed
@sylvestre

Copy link
Copy Markdown
Contributor

Thanks for your PR

@oech3
oech3 deleted the stty-rfd branch October 15, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants