Repository navigation
Conversation
oech3
force-pushed
the
stty-vec
branch
2 times, most recently
from
October 15, 2026 09:12
0e7664c to
6d8a405
Compare
sylvestre
reviewed
Oct 15, 2026
| fn combo_to_flags(combo: &str) -> Vec<ArgOptions<'_>> { | ||
| let mut flags = Vec::new(); | ||
| let mut ccs = Vec::new(); | ||
| let mut ccs: &[(S, &str)] = &[]; |
Contributor
There was a problem hiding this comment.
could the match return a (flags, ccs) tuple so ccs doesn't need mut either?
Contributor
Author
There was a problem hiding this comment.
I avoided it since we need to have many &[].
Contributor
Author
There was a problem hiding this comment.
Applied. Diff is sad.
Contributor
There was a problem hiding this comment.
An alternative might be to separate the handling of flags and ccs, and move each into a function returning a Vec<ArgOptions>.
oech3
force-pushed
the
stty-vec
branch
2 times, most recently
from
October 15, 2026 13:16
4574fdf to
929b997
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.