Repository navigation
install: report why a target cannot be used as a directory - #15365
Merged
Merged
Conversation
limadog9
commented
Oct 15, 2026
limadog9
commented
Contributor
sylvestre
reviewed
Oct 15, 2026
| } | ||
| if reason.kind() == std::io::ErrorKind::NotFound { | ||
| // A trailing slash requires a directory even when its parent exists. | ||
| let reason = if is_new_file_path(target_dir) { |
Contributor
There was a problem hiding this comment.
the shadowed reason is a bit hard to follow, could this be flattened?
limadog9
force-pushed
the
fix/install-target-diagnostic
branch
from
October 15, 2026 12:27
fe34847 to
7179c4d
Compare
Contributor
Author
|
@sylvestre Flattened this with an early return and a separate create_error binding, removing the shadowed reason. Squashed into one commit; all install tests pass. Thanks for the review! |
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.