Skip to content

cksum: reject empty checksum filenames on WASI - #15364

Open
limadog9 wants to merge 1 commit into
uutils:mainfrom
limadog9:fix/checksum-empty-filename-wasi
Open

limadog9 wants to merge 1 commit into
uutils:mainfrom
limadog9:fix/checksum-empty-filename-wasi

Conversation

@limadog9

Copy link
Copy Markdown
Contributor
Handle empty checksum filenames correctly on WASI. Closes #15357.

@codspeed

codspeed Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ 121 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 399 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation factor_five_38_bit_primes 1.8 s 1.8 s -4.37%
⚡ Simulation factor_three_39_bit_primes 800.7 ms 560.7 ms +42.8%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing limadog9:fix/checksum-empty-filename-wasi (b8e8a2f) with main (2fb77e8)

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Comment thread tests/by-util/test_b2sum.rs Outdated
Comment on lines +197 to +200
for line in [format!("{digest} "), format!(" {digest}\t")] {
new_ucmd!()
.arg("--check")
.pipe_in(format!("{line}\n"))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for line in [format!("{digest} "), format!(" {digest}\t")] {
new_ucmd!()
.arg("--check")
.pipe_in(format!("{line}\n"))
for line in [format!("{digest} \n"), format!(" {digest}\t\n")] {
new_ucmd!()
.arg("--check")
.pipe_in(line)

No need to wrap the digest in 2 formats

@limadog9
limadog9 force-pushed the fix/checksum-empty-filename-wasi branch from 0b810bc to b8e8a2f Compare October 15, 2026 12:45
@limadog9

Copy link
Copy Markdown
Contributor Author

@RenjiSann Applied your suggestion and removed the extra formatting step. Native and WASI regression checks pass. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants