Repository navigation
Conversation
limadog9
commented
Oct 15, 2026
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_five_38_bit_primes |
1.8 s | 1.8 s | -4.37% |
| ⚡ | Simulation | factor_three_39_bit_primes |
800.7 ms | 560.7 ms | +42.8% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing limadog9:fix/checksum-empty-filename-wasi (b8e8a2f) with main (2fb77e8)
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
| for line in [format!("{digest} "), format!(" {digest}\t")] { | ||
| new_ucmd!() | ||
| .arg("--check") | ||
| .pipe_in(format!("{line}\n")) |
There was a problem hiding this comment.
| for line in [format!("{digest} "), format!(" {digest}\t")] { | |
| new_ucmd!() | |
| .arg("--check") | |
| .pipe_in(format!("{line}\n")) | |
| for line in [format!("{digest} \n"), format!(" {digest}\t\n")] { | |
| new_ucmd!() | |
| .arg("--check") | |
| .pipe_in(line) |
No need to wrap the digest in 2 formats
0b810bc to
b8e8a2f
Compare
|
@RenjiSann Applied your suggestion and removed the extra formatting step. Native and WASI regression checks pass. Thanks! |