uucore: add cross-platform effective access by anastygnome · Pull Request #15294 · uutils/coreutils

anastygnome · 2026-10-13T04:40:19Z

Move the effective access to FS to allow usage in all utils, and make the syntax similar to rustix

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

codspeed · 2026-10-13T05:24:22Z

Merging this PR will not alter performance

⚠️

124 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

du_deep_tree[(100, 3)]

du_wide_tree[(5000, 500)]

du_all_wide_tree[(5000, 500)]

dd_copy_64k_blocks

cksum_raw_output

cksum_sysv

cksum_default

cksum_multiple_files

cksum_crc

du_summarize_balanced_tree[(5, 4, 10)]

…and 114 more

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

sort_dictionary_order[500000]

✅ 401 untouched benchmarks
⏩ 70 skipped benchmarks¹

_{Comparing anastygnome:uucore-effective-access (18a6ab0) with main (865774e)²}

70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (1f30787) during the generation of this report, so 865774e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

anastygnome · 2026-10-13T06:17:58Z

@cakebaker @sylvestre The lack of effective access checks has caused a lot of issues recently, can you give your opinion on this?

The uucore commit's windows code is functionnally equivalent to the one that was removed in test/platform/windows (second commit)

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

anastygnome · 2026-10-14T06:30:19Z

@sylvestre This can carry security implications (perms related)

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 04:40

Copilot AI reviewed Oct 13, 2026

anastygnome force-pushed the uucore-effective-access branch from db11f50 to 4305db5 Compare October 13, 2026 04:54

Copilot AI balanced review requested due to automatic review settings October 13, 2026 04:54

Copilot AI reviewed Oct 13, 2026

anastygnome mentioned this pull request Oct 13, 2026

mv: decide overwrite prompts by effective write access #15282

Open

anastygnome force-pushed the uucore-effective-access branch from 4305db5 to d26a8e5 Compare October 13, 2026 05:23

Copilot AI balanced review requested due to automatic review settings October 13, 2026 05:23

Copilot AI reviewed Oct 13, 2026

anastygnome force-pushed the uucore-effective-access branch 2 times, most recently from 70767b3 to 7d0a39c Compare October 13, 2026 05:28

Copilot AI balanced review requested due to automatic review settings October 13, 2026 06:17

anastygnome force-pushed the uucore-effective-access branch from 7d0a39c to b48337d Compare October 13, 2026 06:17

Copilot AI reviewed Oct 13, 2026

Copilot AI balanced review requested due to automatic review settings October 14, 2026 06:17

anastygnome force-pushed the uucore-effective-access branch from b48337d to 23c53ff Compare October 14, 2026 06:17

Copilot AI reviewed Oct 14, 2026

anastygnome force-pushed the uucore-effective-access branch from 23c53ff to a65613f Compare October 14, 2026 06:21

Copilot AI balanced review requested due to automatic review settings October 14, 2026 06:21

Copilot AI reviewed Oct 14, 2026

anastygnome requested a balanced review from Copilot October 14, 2026 06:30

Copilot AI reviewed Oct 14, 2026

Copilot AI balanced review requested due to automatic review settings October 14, 2026 06:35

anastygnome force-pushed the uucore-effective-access branch from a65613f to 78c66e6 Compare October 14, 2026 06:35

Copilot AI reviewed Oct 14, 2026

Copilot AI balanced review requested due to automatic review settings October 14, 2026 06:52

anastygnome force-pushed the uucore-effective-access branch from 78c66e6 to 16a3b6c Compare October 14, 2026 06:52

xtqqczze reviewed Oct 18, 2026

View reviewed changes

Comment thread src/uu/test/src/platform/windows.rs Outdated

anastygnome force-pushed the uucore-effective-access branch from 10a4365 to cb16698 Compare October 18, 2026 10:49

Copilot AI balanced review requested due to automatic review settings October 18, 2026 10:49

Copilot AI reviewed Oct 18, 2026

anastygnome requested a review from xtqqczze October 18, 2026 10:50

xtqqczze reviewed Oct 18, 2026

View reviewed changes

Comment thread src/uu/sort/src/sort.rs Outdated

Copilot AI balanced review requested due to automatic review settings October 18, 2026 11:10

anastygnome force-pushed the uucore-effective-access branch from cb16698 to c51f264 Compare October 18, 2026 11:10

Copilot AI reviewed Oct 18, 2026

anastygnome force-pushed the uucore-effective-access branch from c51f264 to 70c3949 Compare October 18, 2026 11:16

Copilot AI balanced review requested due to automatic review settings October 18, 2026 11:16

Copilot AI reviewed Oct 18, 2026

Copilot AI balanced review requested due to automatic review settings October 18, 2026 11:18

anastygnome force-pushed the uucore-effective-access branch from 70c3949 to 7514db1 Compare October 18, 2026 11:18

Copilot AI reviewed Oct 18, 2026

anastygnome force-pushed the uucore-effective-access branch from 7514db1 to 3092412 Compare October 18, 2026 11:22

Copilot AI balanced review requested due to automatic review settings October 18, 2026 12:17

anastygnome force-pushed the uucore-effective-access branch from 3092412 to b879e98 Compare October 18, 2026 12:17

Copilot AI reviewed Oct 18, 2026

anastygnome force-pushed the uucore-effective-access branch from b879e98 to 18a6ab0 Compare October 18, 2026 12:36

anastygnome requested a review from xtqqczze October 18, 2026 16:44

anastygnome added 6 commits October 18, 2026 18:44

uucore: add cross-platform effective access

062886a

test: use shared effective access

bd9bd55

cp: use effective access for destinations

dcb7894

mv: use effective access for overwrite prompts

8a1fcc4

rm: use effective access for permission checks

e337bc4

sort: use shared effective access checks

1ed6364

Copilot AI balanced review requested due to automatic review settings October 18, 2026 16:44

anastygnome force-pushed the uucore-effective-access branch from 18a6ab0 to 1ed6364 Compare October 18, 2026 16:44

Copilot AI reviewed Oct 18, 2026

Conversation

anastygnome commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

anastygnome commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

anastygnome commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anastygnome commented Oct 13, 2026 •

edited

Loading

codspeed Bot commented Oct 13, 2026 •

edited

Loading

anastygnome commented Oct 13, 2026 •

edited

Loading