touch: read -d dates in the local zone and honor their offsets by jay23606 · Pull Request #15292 · uutils/coreutils

jay23606 · 2026-10-13T00:12:27Z

touch -d read a date without an offset, such as 2026-08-01 12:00:00, as UTC. It now reads it in the system zone, as the documentation describes.

This also changes dates that have an offset. The offset used to be dropped, so 2004-01-16 12:00 +0200 was set to 12:00 UTC. It now honors the offset and sets 10:00 UTC. test_touch_set_date7 has its expected value updated to match.

Closes #15291

Integration tests set TZ to a non-UTC zone and check fixed timestamps for both forms. Run locally on Windows only. Six symlink tests fail there for a privilege reason, unrelated to this change.

touch -d read "YYYY-MM-DD HH:MM:SS" as UTC. GNU touch reads it as local time. Use the system zone for the formats that carry no offset. Adds a unit test that fails on the UTC behaviour.

Copilot

🟡 Changes recommended

The locale-format path remains UTC, and the regression test is ineffective on UTC hosts.

1 open finding

Apply system-zone conversion to POSIX_LOCALE date parsing · New

What changed in this PR

Updates touch -d to interpret offset-less numeric timestamps in the system time zone.

Changes:

Uses the local zone for numeric dates without offsets.
Adds a unit regression test.

File	Description
`src/uu/touch/src/touch.rs`	Updates date parsing and adds coverage.

🧠 Review effort: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

🟡 Changes recommended

Explicit offsets are discarded, and the regression tests are ineffective on UTC CI hosts.

2 open findings

1 resolved since last review

Apply system-zone conversion to POSIX_LOCALE date parsing

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

The regression tests pass under the previous behavior on UTC-based CI runners and need an explicit non-UTC zone.

2 open findings

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

The primary regression test is nondeterministic on UTC hosts, and the description omits the explicit-offset behavior change.

2 open findings

1 resolved since last review

Preserve parsed timezone offsets when converting timestamps

🧠 Review effort: Balanced

The unit tests compared against the system zone, which is UTC on UTC CI hosts, so they passed without the local-zone behavior. Move the coverage to integration tests that set TZ to a non-UTC zone and check fixed epochs. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>

Copilot

🔵 Needs a closer look

The description incorrectly claims explicit-offset behavior is unchanged.

1 open finding

PR description omits changed behavior for nonzero %z inputs

1 resolved since last review

Test timestamp conversion under a non-UTC system timezone

🧠 Review effort: Balanced

Copilot

🟢 Approval recommended

The focused implementation correctly addresses both reported parsing errors with adequate regression coverage.

0 open findings

1 resolved since last review

PR description omits changed behavior for nonzero %z inputs

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

Nonexistent local times during DST gaps can fall through and be silently normalized.

1 open finding

Reject nonexistent DST-gap times in -d date parsing · New

🧠 Review effort: Balanced

parse_datetime normalizes a wall-clock time the zone skipped, so -d read 02:30 on a spring-forward day as a real time. Refuse it before the fallback, as the date utility does, and cover it with a -d test. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>

Copilot

🟢 Approval recommended

The focused implementation is consistent with the reported behavior and includes adequate regression coverage.

0 open findings

1 resolved since last review

Reject nonexistent DST-gap times in -d date parsing

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

DST-gap detection misses accepted formats, and existing fixed-epoch tests become host-timezone-dependent.

1 open finding

Set TZ=UTC for date and reference test comparisons · New

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

The DST-gap guard misses accepted minute-only timestamps, allowing silent normalization.

2 open findings

🧠 Review effort: Balanced

Copilot

🔵 Needs a closer look

DST-gap detection misses the supported minute-only date format.

2 open findings

🧠 Review effort: Balanced

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>

Copilot

🔵 Needs a closer look

Minute-only timestamps bypass the new daylight-saving gap validation.

2 open findings

Previously missed (1)

In code that hasn't changed since last review

Reject nonexistent DST times consistently regardless of minute format

src/uu/touch/src/touch.rs:885

Include %Y-%m-%d %H:%M in this guard and add a regression test: with TZ=EST+5EDT,M3.2.0/2,M11.1.0/2, -d '2020-03-08 02:30' bypasses the gap check and reaches the normalizing fallback, while the equivalent input ending in :00 is rejected.

🧠 Review effort: Balanced

codspeed · 2026-10-15T09:31:54Z

Merging this PR will regress 2 benchmarks

⚠️

119 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

du_deep_tree[(100, 3)]

cksum_default

cksum_multiple_files

cksum_crc32b

dd_copy_partial

dd_copy_64k_blocks

du_summarize_balanced_tree[(5, 4, 10)]

dd_copy_4k_blocks

cksum_sysv

factor_multiple_u64s[2]

…and 109 more

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

sort_dictionary_order[500000]

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 398 untouched benchmarks
⏩ 70 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`factor_thirteen_39_bit_primes`	8.7 s	9.6 s	-9.45%
❌	Simulation	`factor_five_38_bit_primes`	1.8 s	1.9 s	-4.89%
⚡	Simulation	`factor_three_39_bit_primes`	800.7 ms	593.8 ms	+34.84%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing jay23606:fix/15291-touch-local-time (09e5fac) with main (2fb77e8)}

70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

parse_datetime accepts 'YYYY-MM-DD HH:MM' and normalizes a time the zone skipped, while the seconds forms were already refused. Check the minute-only form too, with a regression test. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>

Copilot

🔵 Needs a closer look

Cross-platform timezone behavior still needs confirmation from Linux, macOS, and Windows CI.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

touch: read a date without an offset in the local zone

6044832

touch -d read "YYYY-MM-DD HH:MM:SS" as UTC. GNU touch reads it as local time. Use the system zone for the formats that carry no offset. Adds a unit test that fails on the UTC behaviour.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 00:12

Copilot started reviewing on behalf of jay23606 October 13, 2026 00:12

View session