Repository navigation
chgrp: reject the :gid format for the group operand - #15284
vatsanbalaji-ossagent wants to merge 2 commits into
Conversation
GNU chgrp only accepts a group name or numeric ID as the group operand and rejects ":1000" as an invalid group. Only --from accepts the :gid format, so parse the operand separately and add a regression test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| } | ||
|
|
||
| #[test] | ||
| fn test_invalid_group_with_colon_prefix() { |
There was a problem hiding this comment.
test_numeric_group_formats still expects :gid to work as the target group, which is why CI is red. please update it
test_numeric_group_formats still passed ":gid" as the group operand, which is now rejected. Use the plain numeric gid instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for catching this! I missed this locally because the test is skipped on macOS due to |
Merging this PR will degrade performance by 22.05%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_three_39_bit_primes |
321.7 ms | 597 ms | -46.11% |
| ❌ | Simulation | factor_five_38_bit_primes |
1.5 s | 1.8 s | -15.51% |
| ⚡ |
Simulation | du_all_wide_tree[(5000, 500)] |
35.7 ms | 34.3 ms | +4.02% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing vatsanbalaji-ossagent:chgrp-colon-group (2a0c5fc) with main (1747ba1)
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Currently,
chgrpaccepts group operands like:1000, even though GNU coreutils rejects this format. This change separates the group operand parsing from--fromparsing, so the:gidsyntax remains supported for--frombut is rejected as a group operand. A regression test is also added to verify the behavior.Closes #12792
🤖 Generated with Claude Code